From: "Rich Baum" <baumr1@coral.indstate.edu>
To: Keith Owens <kaos@ocs.com.au>, linux-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compile warnings in 2.4.0
Date: Mon, 8 Jan 2001 07:38:10 -0500 [thread overview]
Message-ID: <3A596E62.7415.1048C8@localhost> (raw)
In-Reply-To: Your message of "Sun, 07 Jan 2001 16:19:50 CDT." <3A589726.5449.291B75@localhost>
In-Reply-To: <9097.978915147@ocs3.ocs-net>
On 8 Jan 2001, at 11:52, Keith Owens wrote:
> On Sun, 7 Jan 2001 16:19:50 -0500,
> "Rich Baum" <baumr1@coral.indstate.edu> wrote:
> >This patch should fix the rest of the warnings about #endif
> >statements when using the 20001225 gcc snapshot. Thanks to
> >Keith Owens for providing a script to automate this process. It got
> >the job done sooner and found warnings to fix for non x86 platforms.
>
> As reported by Neil Booth, your patch contains errors which do not
> appear in my patched system using my script. You probably skipped the
> leading '^' in the regexp. It also turns out that there are a couple
> of m68k assembler lines which have a trailing '#' which starts a
> comment on that assembler. So treat '#' as a comment marker as well.
>
> Whatever you used, it was not my script. It should be (with '#' added)
>
> find -type f -name '*.[chS]' | \
> xargs perl -lpi -e 's:^(\s*#\s*endif)\s+([^/\s#].*)$:\1\t/* \2 */:;'
>
> BTW, until the patch is correct do not bother sending it to Alan Cox or
> Linus, just to linux-kernel..
>
You're right I left off the first ^. From know on I'll just go back to my
method of checking my compile logs for errors and manually fixing
them. I'll let other people handle non x86 platforms.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-08 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-07 21:19 [PATCH] Fix compile warnings in 2.4.0 Rich Baum
2001-01-07 22:21 ` Neil Booth
2001-01-08 0:52 ` Keith Owens
2001-01-08 12:38 ` Rich Baum [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-01-06 13:54 Rich Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A596E62.7415.1048C8@localhost \
--to=baumr1@coral.indstate.edu \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=richbaum@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox