* Re: Subtle MM bug - 2 errors in MM code in pre-2.4.1?
@ 2001-01-09 18:16 Benjamin Redelings I
0 siblings, 0 replies; only message in thread
From: Benjamin Redelings I @ 2001-01-09 18:16 UTC (permalink / raw)
To: linux-kernel
Hi -
Based on my quick reading of this patch:
+
+empty:
+ spin_lock(&mmlist_lock);
+ return 0;
The above should actually be spin_UNlock?
Also the test for !inactive_shortage() seems to be inverted?
+ /* If refill_inactive_scan failed, try to page stuff out.. */
+ swap_out(priority, gfp_mask);
+ } while (!inactive_shortage());
-BenRI
--
"...assisted of course by pride, for we teach them to describe the
Creeping Death, as Good Sense, or Maturity, or Experience."
- "The Screwtape Letters"
Benjamin Redelings I <>< http://www.bol.ucla.edu/~bredelin/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-01-09 18:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-01-09 18:16 Subtle MM bug - 2 errors in MM code in pre-2.4.1? Benjamin Redelings I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox