public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Ellmore <steve@signalstorm.com>
To: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: typo in buffer_busy macro in fs/buffer.c ??
Date: Fri, 19 Jan 2001 01:11:14 +0000	[thread overview]
Message-ID: <3A679432.8060609@signalstorm.com> (raw)


This looks like a typo:
(line 2341 of fs/buffer.c in unpatched 2.4.0
line 2345 of fs/buffer.c in 2.4.1-pre8)

#define buffer_busy(bh) (atomic_read(&(bh)->b_count) | ((bh)->b_state &
BUFFER_BUSY_BITS))

surely, it should be:
#define buffer_busy(bh) (atomic_read(&(bh)->b_count) || ((bh)->b_state &
BUFFER_BUSY_BITS))

i.e. logical OR instead of bitwise.

Shouldn't it?


-Steve Ellmore



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

                 reply	other threads:[~2001-01-19  1:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A679432.8060609@signalstorm.com \
    --to=steve@signalstorm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox