public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: andrewm@uow.edu.au, linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: flush_scheduled_tasks() question
Date: Mon, 29 Jan 2001 11:15:47 +0100	[thread overview]
Message-ID: <3A7542D3.FD9CA259@colorfullife.com> (raw)
In-Reply-To: <3A744820.2C4C94F6@colorfullife.com> <30086.980762036@redhat.com>

David Woodhouse wrote:
> 
> -static struct tq_struct dummy_task;
> +static struct tq_struct dummy_task /* = all zero */;
>
That comment is superflous - that's just C.
The non-obvious part is

+static struct tq_struct dummy_task; /* remains zero, run_task_queue()
supports tqs.routine==NULL*/

BUT: The implementation isn't thread safe: what if multiple threads call
flush_scheduled_tasks()?

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2001-01-29 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-28 16:26 flush_scheduled_tasks() question Manfred Spraul
2001-01-29  9:53 ` David Woodhouse
2001-01-29 10:15   ` Manfred Spraul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A7542D3.FD9CA259@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=andrewm@uow.edu.au \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox