* [PATCH] No VIA IDE DMA unless configured
@ 2001-01-23 21:46 Tobias Ringstrom
2001-01-24 9:24 ` Vojtech Pavlik
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Ringstrom @ 2001-01-23 21:46 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Vojtech Pavlik, Kernel Mailing List
Linus, please consider this patch for 2.4.1. It makes sure the VIA IDE
driver does not enable DMA automatically, unless the user has requested it
using "make whateverconfig".
/Tobias
--- via82cxxx.c.orig Tue Jan 23 22:26:25 2001
+++ via82cxxx.c Tue Jan 23 22:27:05 2001
@@ -602,7 +602,9 @@
#ifdef CONFIG_BLK_DEV_IDEDMA
if (hwif->dma_base) {
hwif->dmaproc = &via82cxxx_dmaproc;
+#ifdef CONFIG_IDEDMA_AUTO
hwif->autodma = 1;
+#endif /* CONFIG_IDEDMA_AUTO */
}
#endif /* CONFIG_BLK_DEV_IDEDMA */
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] No VIA IDE DMA unless configured
2001-01-23 21:46 [PATCH] No VIA IDE DMA unless configured Tobias Ringstrom
@ 2001-01-24 9:24 ` Vojtech Pavlik
2001-01-30 20:14 ` Stephen Clark
0 siblings, 1 reply; 4+ messages in thread
From: Vojtech Pavlik @ 2001-01-24 9:24 UTC (permalink / raw)
To: Tobias Ringstrom; +Cc: Linus Torvalds, Kernel Mailing List
On Tue, Jan 23, 2001 at 10:46:14PM +0100, Tobias Ringstrom wrote:
> Linus, please consider this patch for 2.4.1. It makes sure the VIA IDE
> driver does not enable DMA automatically, unless the user has requested it
> using "make whateverconfig".
>
> /Tobias
>
> --- via82cxxx.c.orig Tue Jan 23 22:26:25 2001
> +++ via82cxxx.c Tue Jan 23 22:27:05 2001
> @@ -602,7 +602,9 @@
> #ifdef CONFIG_BLK_DEV_IDEDMA
> if (hwif->dma_base) {
> hwif->dmaproc = &via82cxxx_dmaproc;
> +#ifdef CONFIG_IDEDMA_AUTO
> hwif->autodma = 1;
> +#endif /* CONFIG_IDEDMA_AUTO */
> }
> #endif /* CONFIG_BLK_DEV_IDEDMA */
> }
>
Linus, if you haven't applied my disable-dma-in-all-cases patch I've
sent you earlier, please do apply this one - it's correct and should be
there. It conflicts with the older one, obviously.
--
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] No VIA IDE DMA unless configured
2001-01-24 9:24 ` Vojtech Pavlik
@ 2001-01-30 20:14 ` Stephen Clark
2001-01-30 20:50 ` Andre Hedrick
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Clark @ 2001-01-30 20:14 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: Tobias Ringstrom, Linus Torvalds, Kernel Mailing List
Guys,
from .config on 2.4.1
CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_OFFBOARD is not set
CONFIG_IDEDMA_PCI_AUTO=y
CONFIG_BLK_DEV_IDEDMA=y
Shouldn' t the value be CONFIG_IDEDMA_PCI_AUTO instead of CONFIG_IDEDMA_AUTO
in the code below?
Steve
Vojtech Pavlik wrote:
> On Tue, Jan 23, 2001 at 10:46:14PM +0100, Tobias Ringstrom wrote:
>
> > Linus, please consider this patch for 2.4.1. It makes sure the VIA IDE
> > driver does not enable DMA automatically, unless the user has requested it
> > using "make whateverconfig".
> >
> > /Tobias
> >
> > --- via82cxxx.c.orig Tue Jan 23 22:26:25 2001
> > +++ via82cxxx.c Tue Jan 23 22:27:05 2001
> > @@ -602,7 +602,9 @@
> > #ifdef CONFIG_BLK_DEV_IDEDMA
> > if (hwif->dma_base) {
> > hwif->dmaproc = &via82cxxx_dmaproc;
> > +#ifdef CONFIG_IDEDMA_AUTO
> > hwif->autodma = 1;
> > +#endif /* CONFIG_IDEDMA_AUTO */
> > }
> > #endif /* CONFIG_BLK_DEV_IDEDMA */
> > }
> >
>
> Linus, if you haven't applied my disable-dma-in-all-cases patch I've
> sent you earlier, please do apply this one - it's correct and should be
> there. It conflicts with the older one, obviously.
>
> --
> Vojtech Pavlik
> SuSE Labs
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] No VIA IDE DMA unless configured
2001-01-30 20:14 ` Stephen Clark
@ 2001-01-30 20:50 ` Andre Hedrick
0 siblings, 0 replies; 4+ messages in thread
From: Andre Hedrick @ 2001-01-30 20:50 UTC (permalink / raw)
To: Stephen Clark
Cc: Vojtech Pavlik, Tobias Ringstrom, Linus Torvalds,
Kernel Mailing List
On Tue, 30 Jan 2001, Stephen Clark wrote:
> Guys,
>
> from .config on 2.4.1
> CONFIG_BLK_DEV_IDEDMA_PCI=y
> # CONFIG_BLK_DEV_OFFBOARD is not set
> CONFIG_IDEDMA_PCI_AUTO=y
> CONFIG_BLK_DEV_IDEDMA=y
>
> Shouldn' t the value be CONFIG_IDEDMA_PCI_AUTO instead of CONFIG_IDEDMA_AUTO
> in the code below?
No 'CONFIG_IDEDMA_AUTO' is a global config option across all platforms.
Andre Hedrick
Linux ATA Development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-01-30 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-01-23 21:46 [PATCH] No VIA IDE DMA unless configured Tobias Ringstrom
2001-01-24 9:24 ` Vojtech Pavlik
2001-01-30 20:14 ` Stephen Clark
2001-01-30 20:50 ` Andre Hedrick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox