public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix
@ 2001-02-03  7:43 Anwar Payyoorayil
  2001-01-03 14:16 ` Alan Cox
  2001-01-27  1:52 ` Linux 2.4 hangs on PowerBook 150(m68k) Rafael Diniz
  0 siblings, 2 replies; 3+ messages in thread
From: Anwar Payyoorayil @ 2001-02-03  7:43 UTC (permalink / raw)
  To: Linux Kernel

Alan -

Based on your suggestion, I looked again, and found that even though the kernel
sets VRA, the bit is lost when the driver unnecessarily resets the CODEC. The
patch below removes the unnecessary resetting of the CODEC. Nothing seems to be
lost by removing the resetting, and the driver in 2.2 series (where VRA works
fine) does not do this reset.

If we find that somebody needs this reset, we can move the VRA enabling code
after the codec reset code.

Anwar.

Patch against 2.4.0-prerelease-ac4

--- linux/drivers/sound/i810_audio.c.ac4        Sat Feb  3 01:26:31 2001
+++ linux/drivers/sound/i810_audio.c    Sat Feb  3 01:26:54 2001
@@ -1898,11 +1898,6 @@
        pci_dev->driver_data = card;
        pci_dev->dma_mask = I810_DMA_MASK;
 
-//     printk("resetting codec?\n");
-       outl(0, card->iobase + GLOB_CNT);
-       udelay(500);
-//     printk("bringing it back?\n");
-       outl(1<<1, card->iobase + GLOB_CNT);
        return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-01-27  2:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-02-03  7:43 [PATCH] 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix Anwar Payyoorayil
2001-01-03 14:16 ` Alan Cox
2001-01-27  1:52 ` Linux 2.4 hangs on PowerBook 150(m68k) Rafael Diniz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox