public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Gérard Roudier <groudier@club-internet.fr>,
	"Maciej W. Rozycki" <macro@ds2.pg.gda.pl>,
	Linus Torvalds <torvalds@transmeta.com>,
	Andrew Morton <andrewm@uow.edu.au>,
	Ingo Molnar <mingo@chiara.elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.0, 2.4.0-ac12: APIC lock-ups
Date: Sat, 03 Feb 2001 13:14:37 +0100	[thread overview]
Message-ID: <3A7BF62D.74B81526@colorfullife.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10102021848290.785-100000@linux.local> <3A7B3204.6A433394@colorfullife.com>

Manfred Spraul wrote:
> 
> But I think we can change the bug description:
> 
> If an io apic io redirection entry is unmasked while the irq pin is
> active, then the io apic sends out the interrupt as edge triggered, but
> nevertheless sets the IRR bit.
>

I found another workaround:
8390.c currently calls

	outb_p(ENISR_ALL, e8390_base + EN0_IMR);
	enable_irq(dev->irq);

and locks up after ~ 100 packets flood ping.

If I reorder these calls to

	enable_irq(dev->irq);
	outb_p(ENISR_ALL, e8390_base + EN0_IMR);
	(and the correct spin_lock()'s)

the lockup disappears.

But I have no idea how io_apic.c could prevent lockups.

Playing with the trigger mode is not 100% reliable - I assume it kicks
the io apic only after several changes of the trigger mode bit. Maciej's
patch switches that bit twice during every start_tx operation and thus
doesn't lock up, my patch touches the redirection entry exactly once and
reliably locks up - even if I change trigger mode, polarity, delivery
mode and vector during enable_level_irq().

Any ideas?

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2001-02-03 12:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-29 18:46 [patch] 2.4.0, 2.4.0-ac12: APIC lock-ups Maciej W. Rozycki
2001-01-29 20:40 ` Manfred Spraul
2001-01-30 11:20   ` Maciej W. Rozycki
2001-02-01  0:58     ` Andrew Morton
2001-02-02 12:08       ` Maciej W. Rozycki
2001-02-02 18:12         ` Gérard Roudier
2001-02-02 22:17           ` Manfred Spraul
2001-02-03 10:28             ` Gérard Roudier
2001-02-03 14:44               ` [test patch] reliable apic lockup with one enable/disable_irq() Manfred
2001-02-05 10:32               ` [patch] 2.4.0, 2.4.0-ac12: APIC lock-ups Maciej W. Rozycki
2001-02-03 12:14             ` Manfred Spraul [this message]
2001-02-05 11:38               ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A7BF62D.74B81526@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=andrewm@uow.edu.au \
    --cc=groudier@club-internet.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@ds2.pg.gda.pl \
    --cc=mingo@chiara.elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox