Fix dependencies for radio-miropcm20

Fix dependencies for radio-miropcm20

[Jocelyn Mayer]

I made a very little patch to avoid
people complaining that the kernel doesn't compile
properly when trying to use radio miropcm20 driver.
(I've seen some of this in french newsgroups...)

This driver always needs the ACI mixer,
so this feature should be enabled when we select
the miropcm driver.
For this, I think we have to change: (in 2.4.0 kernel)

--- Config.in-orig      Sat Feb  3 21:12:16 2001                        
                                                                        
                             
+++ Config.in   Sat Feb  3 21:18:48 2001                                
                                                                        
                             
@@ -22,7 +22,7 @@                                                       
                                                                        
                             
   hex '    GemTek i/o port (0x20c, 0x30c, 0x24c or 0x34c)' 
CONFIG_RADIO_GEMTEK_PORT 34c                                             
                                       
fi                                                                       
                                                                        
                           
dep_tristate '  Maestro on board radio' CONFIG_RADIO_MAESTRO 
$CONFIG_VIDEO_DEV                                                       
                                       
-dep_tristate '  Miro PCM20 Radio' CONFIG_RADIO_MIROPCM20 
$CONFIG_VIDEO_DEV                                                       
                                           
+dep_tristate '  Miro PCM20 Radio' CONFIG_RADIO_MIROPCM20 
$CONFIG_VIDEO_DEV $CONFIG_SOUND_ACI_MIXER                               
                                           
dep_tristate '  SF16FMI Radio' CONFIG_RADIO_SF16FMI $CONFIG_VIDEO_DEV    
                                                                        
                           
if [ "$CONFIG_RADIO_SF16FMI" = "y" ]; then                               
                                                                        
                           
   hex '    SF16FMI I/O port (0x284 or 0x384)' CONFIG_RADIO_SF16FMI_PORT 
284                                                                     
                           

With regards.

Jocelyn Mayer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Fix dependencies for radio-miropcm20

[Robert Siemer]

Hi Jocelyn!

You wrote:

> I made a very little patch to avoid
> people complaining that the kernel doesn't compile
> properly when trying to use radio miropcm20 driver.
> (I've seen some of this in french newsgroups...)

> -dep_tristate '  Miro PCM20 Radio' CONFIG_RADIO_MIROPCM20 
> $CONFIG_VIDEO_DEV                                                       
> +dep_tristate '  Miro PCM20 Radio' CONFIG_RADIO_MIROPCM20 
> $CONFIG_VIDEO_DEV $CONFIG_SOUND_ACI_MIXER                               


This was already discussed some days ago. Arjan said, that the
miropcm20 question comes before the aci question, so this is
useless. - Arjan, this is not true for 'make menuconfig' and 'make
xconfig', isn't it?

Anyway, this solution looks somewhat cleaner to me...
But you can choose on your own:  (:
As the new maintainer I'm offering the patches on

http://www.uni-karlsruhe.de/~Robert.Siemer/Private/

Jocelyn, as my patches also include bugfixes and enhancements
(especially for the miroSOUND pcm20 radio), can you recommend these to
the complaining people. - I want more testers and reports for my
patches...


Thanks,
	Robert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Fix dependencies for radio-miropcm20

[Arjan van de Ven]

On Sun, Feb 04, 2001 at 03:31:25AM +0100, Robert Siemer wrote:
> This was already discussed some days ago. Arjan said, that the
> miropcm20 question comes before the aci question, so this is
> useless. - Arjan, this is not true for 'make menuconfig' and 'make
> xconfig', isn't it?

make [x,menu]config are a bit smarter, but at least make menuconfig has the
annoying behavior of hiding the question for the Miro card until you
magically turn on the ACI mixer in the sound section. This confuses the hell
out of peope when they go through make menuconfig "top bottom".

Greetings,
   Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/