modversions.h source pollution in 2.4

modversions.h source pollution in 2.4

[Keith Owens]

The following files explicitly include linux/modversions.h.  They
should not do this, the Makefiles are responsible for automatically
including modversions.h.  Since modversions.h will disappear in 2.5,
consider this advance warning that the offending sources can expect
problems.

Maintainers: please fix these sources by removing modversions.h.

arch/ia64/kernel/palinfo.c
drivers/char/amiserial.c
drivers/char/dtlk.c
drivers/char/ip2.c
drivers/char/ip2main.c
drivers/char/rocket.c
drivers/char/serial.c
drivers/md/lvm.c
drivers/net/eepro100.c
drivers/net/epic100.c
drivers/net/starfire.c
drivers/net/wan/lmc/lmc_main.c

The presence of symbols like foo__ver_foo is not a reason to explicitly
include modversions.h, see http://www.tux.org/lkml/#s8-8.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: modversions.h source pollution in 2.4

[Jeff Garzik]

Keith Owens wrote:
> Maintainers: please fix these sources by removing modversions.h.
[...]
> drivers/net/epic100.c
> drivers/net/starfire.c

Fixed.

	Jeff



-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: modversions.h source pollution in 2.4

[Andreas Dilger]

Keith Owens writes:
> The following files explicitly include linux/modversions.h.  They
> should not do this, the Makefiles are responsible for automatically
> including modversions.h.  Since modversions.h will disappear in 2.5,
> consider this advance warning that the offending sources can expect
> problems.
> 
> Maintainers: please fix these sources by removing modversions.h.

It is not clear from your posting if anything other than removing the
"#include <linux/modversions.h>" line is needed...  Also, what kernel
versions is this needed for?  The LVM code uses a common source file
for 2.2 and 2.4, so should the #include stay in for 2.2?

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: modversions.h source pollution in 2.4

[Alan Cox]

> "#include <linux/modversions.h>" line is needed...  Also, what kernel
> versions is this needed for?  The LVM code uses a common source file
> for 2.2 and 2.4, so should the #include stay in for 2.2?

It shouldnt there for 2.2 either
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: modversions.h source pollution in 2.4

[Keith Owens]

On Mon, 5 Feb 2001 11:16:50 -0700 (MST), 
Andreas Dilger <adilger@turbolinux.com> wrote:
>Keith Owens writes:
>> Maintainers: please fix these sources by removing modversions.h.
>
>It is not clear from your posting if anything other than removing the
>"#include <linux/modversions.h>" line is needed...  Also, what kernel
>versions is this needed for?  The LVM code uses a common source file
>for 2.2 and 2.4, so should the #include stay in for 2.2?

It should be as simple as removing #include <linux/modversions.h>, and
it applies to all kernels, back to 2.1.81.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/