From: Eric Sandeen <sandeen@sgi.com>
To: Michael Rothwell <rothwell@holly-springs.nc.us>
Cc: linux-kernel@vger.kernel.org, Brad Hards <bhards@bigpond.net.au>
Subject: Re: "kaweth" usb ethernet driver in 2.4?
Date: Mon, 05 Feb 2001 10:23:37 -0600 [thread overview]
Message-ID: <3A7ED389.585A9AC5@sgi.com> (raw)
In-Reply-To: <200102040727.f147RAQ14787@513.holly-springs.nc.us> <3A7D919F.F2213EA2@sgi.com> <002301c08f19$c9020100$8501a8c0@gromit>
Ok, so the problem with the current driver is that it will attempt to
load the firmware even if firmware is already loaded. This will hang
the device.
The trick is to look at the device release number
(dev->descriptor.bcdDevice) - if no firmware is present, it returns
0x0002, if firmware is present, it returns 0x0202.
The second trick is to explicitly call usb_get_device_descriptor()
before checking this, as it seems to be cached otherwise. Brad and I
had a simultaneous revelation on this one. :)
Adding this test before the (firmware download, fix download, firmware
trigger) sequence makes things work much more reliably, although it
still fails occasionally if the device is plugged in after the driver is
loaded - fails on usb_get_device_descriptor() for some reason... perhaps
a short delay before re-reading the desriptor might help? (just
guessing here...)
Patches sent to Brad & Michael.
-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-05 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-03 20:22 "kaweth" usb ethernet driver in 2.4? Eric Sandeen
2001-02-04 6:32 ` Michael Rothwell
2001-02-04 17:30 ` Eric Sandeen
2001-02-05 2:17 ` Michael Rothwell
2001-02-05 16:23 ` Eric Sandeen [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-02-05 4:54 Dunlap, Randy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A7ED389.585A9AC5@sgi.com \
--to=sandeen@sgi.com \
--cc=bhards@bigpond.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rothwell@holly-springs.nc.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox