From: Manfred Spraul <manfred@colorfullife.com>
To: Jocelyn Mayer <jocelyn.mayer@netgem.com>, linux-kernel@vger.kernel.org
Subject: Re: FA-311 / Natsemi problems with 2.4.1
Date: Tue, 06 Feb 2001 20:31:45 +0100 [thread overview]
Message-ID: <3A805121.E4D47C32@colorfullife.com> (raw)
In-Reply-To: <3A80425C.8080506@netgem.com>
Jocelyn Mayer wrote:
>
> I'll send my patch for 2.4 kernel
> as soon as I have finished to clean it up !!!
>
A few points:
* set your tabs to 8, and indent by 8 characters.
* Nastemi_auto_negociate: remove the 'static' variable - what if someone
has multiple cards installed?
* You cannot wait for for more than a few dozend microseconds in an
hardware interrupt handle, and a few hundred microseconds in a bottom
half handler (e.g a timer)
Probably the autonegotiation takes longer - add a timer that calls you
back after 50 milliseconds, and return.
And are you sure that a full reset is required for a simple link change?
Most other drivers are written the other way around:
tx_timeout() performs the full reset if the transmitter is hung for > 2
seconds, and link_change only changes the chip configuration.
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-06 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-06 18:28 FA-311 / Natsemi problems with 2.4.1 Jocelyn Mayer
2001-02-06 19:31 ` Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-02-12 8:52 Jocelyn Mayer
2001-02-09 23:16 Tom Popowski
2001-02-06 21:18 Jocelyn Mayer
2001-02-06 23:28 ` Jeff Garzik
2001-02-07 1:45 ` Ben Pharr
2001-02-06 2:29 Misc Mail for Erich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A805121.E4D47C32@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=jocelyn.mayer@netgem.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox