Re: [PATCH] starfire reads irq before pci_enable_device.

Ion Badulescu
2001-02-14T01:36:21Z

On 12 Feb 2001, Jes Sorensen wrote:

> Ion> Yes, but I'd rather let people turn off the always-copy behavior
> Ion> by simply changing rx_copybreak. The unused code is not really
> Ion> that much of a deal, it's only a few lines.
>
> However, it is in the hot path code where it hurts the most.

I couldn't measure any difference, really. And for one extra branch, I
really wouldn't expect a measurable difference..

Not even defining final_version, which removes a *lot* more conditional
branches from the hot path, makes any measurable difference in the CPU
utilization.

Ion

--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.