Re: [PATCH] starfire reads irq before pci_enable_device.

Ion Badulescu
2001-02-09T20:21:41Z

On Fri, 9 Feb 2001, Jeff Garzik wrote:

> For 2.2, define SET_MODULE_OWNER to null.
>
> Define STAR_MOD_INC_USE_COUNT and STAR_MOD_DEC_USE_COUNT. For 2.4,
> these are null. For 2.2, these point to MOD_{INC,DEC}_USE_COUNT.

... and use both SET_MODULE_OWNER and STAR_MOD_*_USE_COUNT. It's along the
lines of what I was thinking -- though I don't think it's very clean.

Thanks a lot for the suggestion.

And one more question: is 2.2.x compatibility stuff acceptable in a 2.4
driver, given that all that stuff is in *one* #ifdef and not sprinkled
throughout the file?

Ion

--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.