Re: [PATCH] starfire reads irq before pci_enable_device.

Jes Sorensen
2001-02-14T15:37:10Z

>>>>> "Donald" == Donald Becker <becker@scyld.com> writes:

Donald> On 12 Feb 2001, Jes Sorensen wrote:
>> In this case it just results in a performance degradation for 99%
>> of the usage. What about making the change so it is optimized away
>> unless IPX is enabled?

Donald> ??? - It's not just IPX hosts that send 802.3 headers. -
Donald> While a good initial value might depend on the architecture,
Donald> the best setting is processor implementation and environment
Donald> dependent. Those details are not known at compile time. -
Donald> The code path cost of a module option is only a compare and a
Donald> conditional branch.

What else is sending out 802.3 frames these days? I really don't care
about IPX when it comes to performance.

I am just advocating that we optimize for the common case which is DIX
frames and not 802.3.

Jes