Re: [PATCH] starfire reads irq before pci_enable_device.

Ion Badulescu
2001-02-09T21:53:10Z

On 9 Feb 2001, Jes Sorensen wrote:

> Manfred> What about changing the default for rx_copybreak instead?
> Manfred> Set it to 1536 on ia64 and Alpha, 0 for the rest. tulip and
> Manfred> eepro100 use that aproach.
>
> Inefficient, my patch will make the unused code path disappear during
> compilation, what you suggest results in an extra branch and unused
> code.

Yes, but I'd rather let people turn off the always-copy behavior by simply
changing rx_copybreak. The unused code is not really that much of a deal,
it's only a few lines.

Ion

--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.