Re: [PATCH] starfire reads irq before pci_enable_device.

Petr Vandrovec
2001-02-14T15:56:31Z

On 14 Feb 01 at 16:35, Jes Sorensen wrote:
> >>>>> "Donald" == Donald Becker <becker@scyld.com> writes:
> Donald> On 12 Feb 2001, Jes Sorensen wrote:

> Donald> ??? - It's not just IPX hosts that send 802.3 headers. -
> Donald> While a good initial value might depend on the architecture,
> Donald> the best setting is processor implementation and environment
> Donald> dependent. Those details are not known at compile time. -
> Donald> The code path cost of a module option is only a compare and a
> Donald> conditional branch.
>
> What else is sending out 802.3 frames these days? I really don't care
> about IPX when it comes to performance.
>
> I am just advocating that we optimize for the common case which is DIX
> frames and not 802.3.

Pardon me, but IPX in 802.3 and IPX in DIX are exactly same frames
on wire, except that IPX/802.3 contains frame length in bytes
0x0C/0x0D, while IPX/DIX contains 0x8137 here. They have same length,
and same length of media header, so I really do not understand.

If you are talking about encapsulation which is known as `ethernet_802.2'
in IPX world, then it is true, it has odd bytes in header. But nobody sane
except Appletalk uses 802.2 now... Our Suns already died due to this couple
of years ago ;-)

And as Ethernet SNAP has 8byte long header, it should be safe too, unless
architecture requires 16byte alignment - so only odd 802.2 should
be baned.
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz