Re: [PATCH] starfire reads irq before pci_enable_device.

Manfred Spraul
2001-02-07T20:34:54Z

Jeff Garzik wrote:
>
> + SET_MODULE_OWNER(dev);
>
> irq = pdev->irq;
>

One question:
The code copies 'pdev->irq' into 'dev->irq'.

Is that required, who need 'dev->irq'?

> retval = request_irq(dev->irq, &intr_handler, SA_SHIRQ, dev->name, dev);

Can't the driver use?
retval = request_irq(np->pci_dev->irq)

--
Manfred