From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Francois Romieu <romieu@cogenit.fr>
Cc: Dimitromanolakis Apostolos <apdim@ovelix.softnet.tuc.gr>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] drivers/media/radio/radio-maxiradio.c - 2.4.1-ac8
Date: Fri, 09 Feb 2001 15:15:56 -0500 [thread overview]
Message-ID: <3A844FFC.D0087A3E@mandrakesoft.com> (raw)
In-Reply-To: <20010206224451.A24412@ensta.fr> <Pine.LNX.4.10.10102072245460.17074-300000@kythira.softlab.tuc.gr> <20010209210806.A1001@se1.cogenit.fr>
Francois Romieu wrote:
> --- linux-2.4.1-ac8.orig/drivers/media/radio/radio-maxiradio.c Fri Feb 9 15:55:03 2001
> +++ linux-2.4.1-ac8/drivers/media/radio/radio-maxiradio.c Fri Feb 9 15:56:55 2001
> @@ -376,9 +376,7 @@
>
> int __init maxiradio_radio_init(void)
> {
> - int count = pci_register_driver(&maxiradio_driver);
> -
> - if(count > 0) return 0; else return -ENODEV;
> + return pci_module_init(&maxiradio_driver);
> }
>
> void __exit maxiradio_radio_exit(void)
Patch looks ok. Further change: move pci_enable_device above the
request_region call. request_region calls pci_resource_start(), which
may not return a proper value if called before pci_enable_device.
Jeff
--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-09 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-06 20:29 Linux 2.4.1-ac4 Alan Cox
2001-02-06 21:44 ` [PATCH] drivers/media/radio/radio-maxiradio.c - 2.4.1-ac4 Francois romieu
2001-02-07 20:55 ` Dimitromanolakis Apostolos
2001-02-09 20:08 ` [PATCH] drivers/media/radio/radio-maxiradio.c - 2.4.1-ac8 Francois Romieu
2001-02-09 20:15 ` Jeff Garzik [this message]
2001-02-09 20:30 ` Francois Romieu
2001-02-07 4:26 ` 2.4.1-ac3 oops decoded with ksymoops Dax Kelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A844FFC.D0087A3E@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=apdim@ovelix.softnet.tuc.gr \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@cogenit.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox