small patch for unsigned char breakage in rtl8129 driver

small patch for unsigned char breakage in rtl8129 driver

[Philip Blundell]

--- linux/drivers/net/rtl8129.c	Sat Nov  4 16:42:22 2000
+++ linux/drivers/net/rtl8129.c	Sat Nov  4 16:48:21 2000
@@ -271,7 +271,7 @@ struct rtl8129_private {
 	unsigned char *tx_bufs;				/* Tx bounce buffer region. */
 	dma_addr_t rx_ring_dma;
 	dma_addr_t tx_bufs_dma;
-	char phys[4];						/* MII device addresses. */
+	signed char phys[4];				/* MII device addresses. */
 	char twistie, twist_cnt;			/* Twister tune state. */
 	unsigned int tx_full:1;				/* The Tx queue is full. */
 	unsigned int full_duplex:1;			/* Full-duplex operation requested. */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: small patch for unsigned char breakage in rtl8129 driver

[Alan Cox]

> -	char phys[4];						/* MII device addresses. */
> +	signed char phys[4];				/* MII device addresses. */

8129 is deprecated for the current 8139too driver which is the only stable
driver for it. Does 8139too (from current -ac) work on ARM ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: small patch for unsigned char breakage in rtl8129 driver

[Jeff Garzik]

Alan Cox wrote:
> 
> > -     char phys[4];                                           /* MII device addresses. */
> > +     signed char phys[4];                            /* MII device addresses. */
> 
> 8129 is deprecated for the current 8139too driver which is the only stable
> driver for it. Does 8139too (from current -ac) work on ARM ?

I've gotten at least one report that it does

	Jeff


-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/