--- linux/drivers/net/pcnet32.c.2.4.1 Wed Feb 14 16:49:31 2001 +++ linux/drivers/net/pcnet32.c Thu Feb 15 13:48:05 2001 @@ -624,10 +624,35 @@ printk(KERN_INFO "%s: %s at %#3lx,", dev->name, chipname, ioaddr); - /* There is a 16 byte station address PROM at the base address. - The first six bytes are the station address. */ + /* In most chips, after a chip reset, the ethernet address is read from the + * station address PROM at the base address and programmed into the + * "Physical Address Registers" CSR12-14. + * As a precautionary measure, we read the PROM values and complain if + * they disagree with the CSRs. Either way, we use the CSR values, and + * double check that they are valid. + */ + for (i = 0; i < 3; i++) { + unsigned int val; + val = a->read_csr(ioaddr, i+12) & 0x0ffff; + /* There may be endianness issues here. */ + dev->dev_addr[2*i] = val & 0x0ff; + dev->dev_addr[2*i+1] = (val >> 8) & 0x0ff; + } + { + u8 promaddr[6]; + for (i = 0; i < 6; i++) { + promaddr[i] = inb(ioaddr + i); + } + if( memcmp( promaddr, dev->dev_addr, 6) ) + printk(" warning: PROM address does not match CSR address"); + } + /* if the ethernet address is not valid, force to 00:00:00:00:00:00 */ + if( !is_valid_ether_addr(dev->dev_addr) ) + for (i = 0; i < 6; i++) + dev->dev_addr[i]=0; + for (i = 0; i < 6; i++) - printk(" %2.2x", dev->dev_addr[i] = inb(ioaddr + i)); + printk(" %2.2x", dev->dev_addr[i] ); if (((chip_version + 1) & 0xfffe) == 0x2624) { /* Version 0x2623 or 0x2624 */ i = a->read_csr(ioaddr, 80) & 0x0C00; /* Check tx_start_pt */ @@ -774,6 +799,10 @@ lp->shared_irq ? SA_SHIRQ : 0, lp->name, (void *)dev)) { return -EAGAIN; } + + /* Check for a valid station address */ + if( !is_valid_ether_addr(dev->dev_addr) ) + return -EINVAL; /* Reset the PCNET32 */ lp->a.reset (ioaddr); --- linux/include/linux/etherdevice.h.2.4.1 Thu Feb 15 11:25:46 2001 +++ linux/include/linux/etherdevice.h Thu Feb 15 13:18:20 2001 @@ -45,6 +45,14 @@ memcpy (dest->data, src, len); } +/* Check that the ethernet address (MAC) is not 00:00:00:00:00:00 and is not + * a multicast address. Return true if the address is valid. + */ +static __inline__ int is_valid_ether_addr( u8 *addr ) +{ + return !(addr[0]&1) && memcmp( addr, "\0\0\0\0\0\0", 6); +} + #endif #endif /* _LINUX_ETHERDEVICE_H */