public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Dalecki <dalecki@evision-ventures.com>
To: Peter Samuelson <peter@cadcamlab.org>
Cc: BERECZ Szabolcs <szabi@inf.elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new setprocuid syscall
Date: Tue, 20 Feb 2001 11:53:21 +0100	[thread overview]
Message-ID: <3A924CA1.10C913E7@evision-ventures.com> (raw)
In-Reply-To: <Pine.A41.4.31.0102192312330.174604-100000@pandora.inf.elte.hu> <20010219230106.A23699@cadcamlab.org>

Peter Samuelson wrote:
> 
> [BERECZ Szabolcs]
> > Here is a new syscall. With this you can change the owner of a running
> > procces.
> 
> > +       if (current->euid)
> > +               return -EPERM;
> 
> Use capable().
> 
> > +       p = find_task_by_pid(pid);
> > +       p->fsuid = p->euid = p->suid = p->uid = uid;
> 
> Race -- you need to make sure the task_struct doesn't disappear out
> from under you.
> 
> Anyway, why not use the interface 'chown uid /proc/pid'?  No new
> syscall, no arch-dependent part, no user-space tool, etc.

Becouse of exactly the same race condition as above maybe?

  reply	other threads:[~2001-02-20 10:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-19 22:18 [PATCH] new setprocuid syscall BERECZ Szabolcs
2001-02-20  5:01 ` Peter Samuelson
2001-02-20 10:53   ` Martin Dalecki [this message]
2001-02-20 13:00     ` Peter Samuelson
2001-02-20 11:42   ` Alan Cox
2001-02-20 13:11     ` Peter Samuelson
2001-02-20 13:52       ` Alan Cox
2001-02-20 17:04         ` BERECZ Szabolcs
2000-01-01  0:28           ` Pavel Machek
2001-02-21  4:19           ` Peter Samuelson
2001-02-20 12:14   ` BERECZ Szabolcs
2001-02-20 12:52     ` Peter Samuelson
2001-02-20 12:02 ` Philipp Rumpf
  -- strict thread matches above, loose matches on Subject: below --
2001-02-20 14:19 Petr Vandrovec
2001-02-23 17:13 Bernd Jendrissek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A924CA1.10C913E7@evision-ventures.com \
    --to=dalecki@evision-ventures.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@cadcamlab.org \
    --cc=szabi@inf.elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox