public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Probably patch-2.4.1 is not complete
@ 2001-02-25 18:41 Nick Kurshev
  2001-02-25 18:21 ` Incorrect CD Drive speed Siddharth Kashyap
  2001-02-25 20:44 ` Probably patch-2.4.1 is not complete J . A . Magallon
  0 siblings, 2 replies; 5+ messages in thread
From: Nick Kurshev @ 2001-02-25 18:41 UTC (permalink / raw)
  To: linux-kernel@vger.kernel.org

Hello!

I have downloaded a full tarball of linux-kernel-2.4.0 and patches: patch-2.4.1 patch-2.4.2.
But patch-2.4.1 imho it not complete. During linking a linker said about unresolved reference:
__buggy_fxsr_alignment
The patch-2.4.1 contain following records:
 /* Enable FXSR and company _before_ testing for FP problems. */
-#if defined(CONFIG_X86_FXSR) || defined(CONFIG_X86_RUNTIME_FXSR)
 	/*
 	 * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
 	 */
-	if (offsetof(struct task_struct, thread.i387.fxsave) & 15)
-		panic("Kernel compiled for PII/PIII+ with FXSR, data not 16-byte aligned!");
-
+	if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
+		extern void __buggy_fxsr_alignment(void);
+		__buggy_fxsr_alignment();
+	}
 	if (cpu_has_fxsr) {
 		printk(KERN_INFO "Enabling fast FPU save and restore... ");
 		set_in_cr4(X86_CR4_OSFXSR);
 		printk("done.\n");
 	}
-#endif

I.e. in version 2.4.0 of kernel this code was conditionally compiled and did not cause any problems.
In 2.4.1 coditional compilation was avoided. In 2.4.2 this place is not modified.
I did an attempt to find out implementation of __buggy_fxsr_alignment but have not found any source which
contains body of function.

I have K6 cpu and for me this piece of code is unnecessary. But already second patch I'm modifing by hand.
May be it would be better for me to download a full tarball of linux-2.4.2?

Any suggestions please!

Best regards! Nick



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2001-02-25 21:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-02-25 18:41 Probably patch-2.4.1 is not complete Nick Kurshev
2001-02-25 18:21 ` Incorrect CD Drive speed Siddharth Kashyap
2001-02-25 19:09   ` Mircea Ciocan
2001-02-25 21:16     ` Jens Axboe
2001-02-25 20:44 ` Probably patch-2.4.1 is not complete J . A . Magallon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox