public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Michal Jaegermann <michal@harddata.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.2ac20
Date: Tue, 13 Mar 2001 18:38:00 -0500	[thread overview]
Message-ID: <3AAEAF58.3F4BDA3B@mandrakesoft.com> (raw)
In-Reply-To: <E14cgXm-0003O5-00@the-village.bc.nu> <20010313161704.A15082@mail.harddata.com>

Michal Jaegermann wrote:
> 
> On Tue, Mar 13, 2001 at 04:36:18AM +0000, Alan Cox wrote:
> ...
> >
> > 2.4.2-ac20
> ...
> > o     Fix Alpha build                                 (Jeff Garzik)
> 
> Now I see (at least on Alpha) a constant wailing:
> 
> ..../linux-2.4.2ac/include/linux/binfmts.h:45: warning: `struct
> mm_struct' declared inside parameter list
> ..../linux-2.4.2ac/include/linux/binfmts.h:45: warning: its scope is
> only this definition or declaration, which is probably not what you want
> 
> Is this somehow related?

Nope, I saw that before the patch.  My patch was, in any case, to a
single .c file, not a header file, so it wouldn't spew like that.

It compiled and booted, I moved on :)

So solve that warning you probably need to shuffle the delicate balance
of includes around so that linux/sched.h, where mm_struct is defined, is
included before binfmts.h.  Or have binfmt.h include sched.h (which
should work... but its all kinds of nested nastiness)

-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full mooon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.

  reply	other threads:[~2001-03-13 23:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-13  4:36 Linux 2.4.2ac20 Alan Cox
2001-03-13  6:28 ` Nathan Walp
2001-03-13 23:17 ` Michal Jaegermann
2001-03-13 23:38   ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-03-13 16:41 David Balazic
2001-03-13 19:24 ` Nathan Walp
2001-03-13 23:02   ` Tim Wright
2001-03-14  9:31   ` David Balazic
2001-03-14 15:12     ` Nathan Walp
2001-03-13 23:41 Douglas Gilbert
2001-03-13 23:46 Wayne.Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AAEAF58.3F4BDA3B@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal@harddata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox