From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Junfeng Yang <yjf@stanford.edu>
Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu
Subject: Re: [CHECKER] 28 potential interrupt errors
Date: Sun, 18 Mar 2001 06:52:02 -0500 [thread overview]
Message-ID: <3AB4A162.17FD434A@mandrakesoft.com> (raw)
In-Reply-To: <Pine.GSO.4.31.0103162216360.10409-100000@elaine24.Stanford.EDU>
Junfeng Yang wrote:
> [BUG] error path
>
> /u2/acc/oses/linux/2.4.1/drivers/net/appletalk/cops.c:776:cops_rx: ERROR:INTR:763:804: Interrupts inconsistent, severity `20':804
Fixed.
Request: can the checker check for skb's being freed correctly? The
rules:
If an skb is in interrupt context, call dev_kfree_skb_irq.
If an skb might be in interrupt context, call dev_kfree_skb_any.
If an skb is not in interrupt context, call dev_kfree_skb.
I also found and fixed an error of this sort on cops.c as well.
> [BUG] error path. this bug is interesting
>
> /u2/acc/oses/linux/2.4.1/drivers/net/pcmcia/wavelan_cs.c:2561:wavelan_get_wireless_stats: ERROR:INTR:2528:2561: Interrupts inconsistent, severity `20':2561
>
> /* Disable interrupts & save flags */
> Start --->
> spin_lock_irqsave (&lp->lock, flags);
>
> if(lp == (net_local *) NULL)
> return (iw_stats *) NULL;
Fixed.
I dunno WTF the programmer was thinking here... Your de-ref checker
should have caught this too: check 'lp' for NULL after de-referencing
lp->lock.
> [BUG] error path
>
> /u2/acc/oses/linux/2.4.1/drivers/net/tokenring/smctr.c:3655:smctr_open_tr: ERROR:INTR:3594:3661: Interrupts inconsistent, severity `20':3661
Seems to be fixed already.
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
next prev parent reply other threads:[~2001-03-18 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-17 6:18 [CHECKER] 28 potential interrupt errors Junfeng Yang
2001-03-17 12:03 ` Andrew Morton
2001-03-17 21:29 ` Junfeng Yang
2001-03-17 22:42 ` David Woodhouse
2001-03-18 0:03 ` Andrew Morton
2001-03-18 13:07 ` David Woodhouse
2001-03-18 18:03 ` Kai Germaschewski
2001-03-18 11:52 ` Jeff Garzik [this message]
2001-03-19 1:53 ` Dawson Engler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AB4A162.17FD434A@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
--cc=yjf@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox