2.2.18: e100.c (SuSE 7.1): udelay() used in a wrong way?

2.2.18: e100.c (SuSE 7.1): udelay() used in a wrong way?

[Ulrich Windl]

>From the source code of drivers/net/e100.c:

/****************************************************************************
 * Name:          Phy82562EHDelayMilliseconds
 *
 * Description:   Stalls execution for a specified number of milliseconds.
 *
 * Arguments:     Time - milliseconds to delay
 *
 * Returns:       Nothing
 *
 
************************************************************************
***/
void
Phy82562EHDelayMilliseconds(int Time)
{
    udelay(Time);
}


AFAIK, udelay() delays microseconds, not milliseconds.

Ulrich

Re: 2.2.18: e100.c (SuSE 7.1): udelay() used in a wrong way?

[Jeff Garzik]

Ulrich Windl wrote:
> void
> Phy82562EHDelayMilliseconds(int Time)
> {
>     udelay(Time);
> }
> 
> AFAIK, udelay() delays microseconds, not milliseconds.

Yep, you are correct, and the code is incorrect.

mdelay() delays milliseconds.

-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full mooon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.