From: Andrew Morton <andrewm@uow.edu.au>
To: Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] vmalloc_area_pages() in 2.4.2-ac25
Date: Mon, 26 Mar 2001 22:23:20 +1000 [thread overview]
Message-ID: <3ABF34B8.C1909C60@uow.edu.au> (raw)
In-Reply-To: <E14hQaE-0001AK-00@the-village.bc.nu>, <E14hQaE-0001AK-00@the-village.bc.nu> <3dc0ojhz.wl@frostrubin.open.nm.fujitsu.co.jp>
Tachino Nobuhiro wrote:
>
> vmalloc_area_pages() in 2.4.2-ac25 seems to be broken. It calls
> spin_lock(&init_mm.page_table_lock) twice and causes system hang.
>
Yes, it would. Delete the innermost lock and unlock.
--- linux-2.4.2-ac25/mm/vmalloc.c Mon Mar 26 21:38:38 2001
+++ ac/mm/vmalloc.c Mon Mar 26 21:52:05 2001
@@ -152,9 +152,7 @@
do {
pmd_t *pmd;
- spin_lock(&init_mm.page_table_lock); /* pmd_alloc requires this */
pmd = pmd_alloc(&init_mm, dir, address);
- spin_unlock(&init_mm.page_table_lock);
ret = -ENOMEM;
if (!pmd)
break;
next prev parent reply other threads:[~2001-03-26 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-26 6:34 Linux 2.4.2ac25 Alan Cox
2001-03-26 9:47 ` ac25 - hang mounting swap J . A . Magallon
2001-03-26 14:52 ` Alan Cox
2001-03-26 17:13 ` J . A . Magallon
2001-03-26 11:30 ` [BUG] vmalloc_area_pages() in 2.4.2-ac25 Tachino Nobuhiro
2001-03-26 12:23 ` Andrew Morton [this message]
2001-03-26 12:52 ` Andrew Morton
2001-03-26 16:42 ` Linux 2.4.2ac25 Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ABF34B8.C1909C60@uow.edu.au \
--to=andrewm@uow.edu.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tachino@open.nm.fujitsu.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox