public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Frank Jacobberger <f1j@xmission.com>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@transmeta.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH] Fix net driver load problems
Date: Mon, 26 Mar 2001 09:29:37 -0500	[thread overview]
Message-ID: <3ABF5251.60EFC4C1@mandrakesoft.com> (raw)
In-Reply-To: <3ABF4D3D.2070401@xmission.com>

[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]

Frank Jacobberger wrote:
> 
> Something has changed regarding the 8139too driver in pre8.
> 
> I worked on it all morning long trying to resolve why the sucker
> failed to load. There are new configuration options that need to
> be addressed. As you recall there were zippo options in the pre7.
> 
> There are now:
> 
> RealTek RTL-8139 PCI Fast Ethernet Adapter support      [M]
>   Use PIO instead of MMIO
>       [*]

Note by selecting this, you must made your driver slower.  Did you read
the help for the option?

>   Support for automatic channel equalization (EXPERIMENTAL)   [ ]
>   Support for older RTL-8129/8130 boards                            [*]

By selecting this you made your driver bigger, probably for no reason..

> Doing any combination of the above netted no positive result here.
> 
> I have run every kernel patch since 2.4.0 blah and
> have never seen this driver fail to load or perform to some degree.
> 
> Trying to do insmod 8139too.o from the :
> /lib/modules/2.4.3-pre8/kernel/drivers/net directory show these
> unresolved symbols:
> 
> 8139too.o: unresolved symbol alloc_etherdev
> 8139too.o: unresolved symbol unregister_netdev
> 8139too.o: unresolved symbol register_netdev
> 
> Maybe Jeff can shed more light on these changes....

After staring hard at my source, I ran another diff and found that
net_init is not listed in export-objs.  Oh well, it's better to compile
stuff into your kernel anyway ;-) ;-)

Attached is a patch which fixes things.

	Jeff


-- 
Jeff Garzik       | May you have warm words on a cold evening,
Building 1024     | a full moon on a dark night,
MandrakeSoft      | and a smooth road all the way to your door.

[-- Attachment #2: makefile.patch --]
[-- Type: text/plain, Size: 828 bytes --]

Index: drivers/net/Makefile
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/net/Makefile,v
retrieving revision 1.1.1.32
retrieving revision 1.1.1.32.2.1
diff -u -r1.1.1.32 -r1.1.1.32.2.1
--- drivers/net/Makefile	2001/03/26 04:48:45	1.1.1.32
+++ drivers/net/Makefile	2001/03/26 05:29:41	1.1.1.32.2.1
@@ -15,8 +15,9 @@
 # All of the (potential) objects that export symbols.
 # This list comes from 'grep -l EXPORT_SYMBOL *.[hc]'.
 
-export-objs     :=	8390.o arlan.o aironet4500_core.o aironet4500_card.o ppp_async.o \
-			ppp_generic.o slhc.o pppox.o auto_irq.o
+export-objs     :=	8390.o arlan.o aironet4500_core.o aironet4500_card.o \
+			ppp_async.o ppp_generic.o slhc.o pppox.o auto_irq.o \
+			net_init.o
 
 ifeq ($(CONFIG_TULIP),y)
   obj-y += tulip/tulip.o

  reply	other threads:[~2001-03-26 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-26 14:07 2.4.3-pre8 problem with 8139too - failure to load Frank Jacobberger
2001-03-26 14:29 ` Jeff Garzik [this message]
2001-03-27  2:06 ` Tom Eastep

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ABF5251.60EFC4C1@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=f1j@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox