Re: Proposal for a new PCI function call

Jeff Garzik
2001-04-12T19:42:59Z

Steve Modica wrote:
>
> Hi All,
>
> We found recently that the acenic driver for the 3com gigabit ethernet card does
> not enable 64 bit DMAs. (this is done by setting the appropriate mask in
> pci_dev->dma_mask).
>
> Jes suggested that the appropriate way to fix this would be to create a function
> like pci_enable_dma64 and then have the driver call that, rather than directly
> setting this value (a small handful of drivers do this now).
>
> I think the function idea would let us do some sanity checking to make sure
> drivers weren't setting this to 64bit on non-64 bit busses and stuff.

pci_set_dma_mask. Modify that to do the additional checks you need.

Nobody should be setting dma_mask directly anymore, it should be done
through this function.

Jeff

--
Jeff Garzik | Sam: "Mind if I drive?"
Building 1024 | Max: "Not if you don't mind me clawing at the dash
MandrakeSoft | and shrieking like a cheerleader."