amiga affs support broken in 2.4.x kernels??

amiga affs support broken in 2.4.x kernels??

[Mark Hounschell]

 I'm not a list member so IF you respond to this mail please CC me.
I've been looking at the archives and see some problems with the 2.3.x
kernel versions and affs support. I havn't tried any 2.3.x versions but
starting with 2.4.0 I can no longer mount an affs file system. No matter
if loopback or an actual device. 2.2.x kernels work greate. Does anyone
KNOW whether this still works or not and if not maybe a patch somwhere
for the 2.4.x kernels. It doesn't appear that anything has changed in
the
/usr/src/linux/fs/affs dircetory since at least 2.2.14 so I beleive the
problem to be else where. I've tried all the versions of util-linux and
all work with 2.2.14/2.2.18. What happens whin I try to mount an affs
fs using the command "mount -t affs /dev/sdc1 /mnt" is the mount command
just hangs and CANNOT be killed. If I access any files on the system
after
the hang I get major file corruption. If I imediatly hit the kill switch
then it is usually recoverable. Any response/help would be greatly
appc'd

Regards
Mark Hounschell
markh@compro.net

Re: amiga affs support broken in 2.4.x kernels??

[Roman Zippel]

Hi,

Mark Hounschell wrote:

>  I'm not a list member so IF you respond to this mail please CC me.
> I've been looking at the archives and see some problems with the 2.3.x
> kernel versions and affs support.

I've put a new version at
http://www.xs4all.nl/~zippel/affs.010414.tar.gz

bye, Roman

Re: amiga affs support broken in 2.4.x kernels??

[Mark Hounschell]

Roman Zippel wrote:
> 
> Hi,
> 
> Mark Hounschell wrote:
> 
> >  I'm not a list member so IF you respond to this mail please CC me.
> > I've been looking at the archives and see some problems with the 2.3.x
> > kernel versions and affs support.
> 
> I've put a new version at
> http://www.xs4all.nl/~zippel/affs.010414.tar.gz
> 
> bye, Roman

Thanks, I can now mount affs filesystems. However when I try to write
to it via "cp somefile /amiga/somefile" I get a segmentation fault. If
I then do a "df -h" it hangs the system very much like the mount command
did before I installed your tar-ball. Was write support expected from
it.
Are you the NEW maintainer of the affs stuff. I very much appreciate
your
response and if I can help in any way just let me know. I use affs quite
a bit here at work in conjunction with UAE and real amigas.

I also received a response from I guess the original
maintainer,           Hans-Joachim Widmaier <hjw@zvw.de>.
I quote:

"?affs is broken since somewhere in 2.3.xx. Alas, I do not have
the time
anymore to do anything about it, and my Amiga ran its last
program, too,
so I cannot test anymore. Last I know is that several guys
wanted to
look after affs in 2.4--at least make it run--, but it seems
that nothing
much has been done in that way. :-(

Sorry for not bearing better news."

unquote:

I was very much relieved to from you as I know have HOPE for a
completely working affs again.

Thanks

Mark Hounschell
markh@compro.net
--

Re: amiga affs support broken in 2.4.x kernels??

[Roman Zippel]

Hi,

Mark Hounschell wrote:

> Thanks, I can now mount affs filesystems. However when I try to write
> to it via "cp somefile /amiga/somefile" I get a segmentation fault. If
> I then do a "df -h" it hangs the system very much like the mount command
> did before I installed your tar-ball. Was write support expected from
> it.

Yes, it should work.
What sort of filesystem is it (ffs or ofs)? Did you check the dmesg
output for an oops? Which kernel version did you use?

> Are you the NEW maintainer of the affs stuff.

Yes and as soon this problem is solved, I'm sending the changes to Linus
and Alan.

bye, Roman

Re: amiga affs support broken in 2.4.x kernels??

[Mark Hounschell]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Roman Zippel wrote:
> 
> Hi,
> 
> Mark Hounschell wrote:
> 
> > Thanks, I can now mount affs filesystems. However when I try to write
> > to it via "cp somefile /amiga/somefile" I get a segmentation fault. If
> > I then do a "df -h" it hangs the system very much like the mount command
> > did before I installed your tar-ball. Was write support expected from
> > it.
> 
> Yes, it should work.
> What sort of filesystem is it (ffs or ofs)? Did you check the dmesg
> output for an oops? Which kernel version did you use?
> 
> > Are you the NEW maintainer of the affs stuff.
> 
> Yes and as soon this problem is solved, I'm sending the changes to Linus
> and Alan.
> 
> bye, Roman

Hello Roman,
 Sorry I didn't get back to you yesterday afternoon. I was out of town.
 Attached is the output from dmesg and the relavent info from
/var/log/messages. I am using a vanilla 2.4.3 kernel with the
affs support compiled in. (No Modules). I beleive the filesystem is ffs
but not exactly sure. How do I tell?

Mark

[-- Attachment #2: xx.dmesg --]
[-- Type: application/octet-stream, Size: 832 bytes --]

Unable to handle kernel NULL pointer dereference at virtual address 00000034
 printing eip:
c01ac1f2
*pde = 00000000
Oops: 0000
CPU:    0
EIP:    0010:[<c01ac1f2>]
EFLAGS: 00010246
eax: c12e8ee0   ebx: 00000000   ecx: c6a0eecc   edx: 00000c09
esi: c6a0ee00   edi: 00000000   ebp: 00000c09   esp: c39b1e3c
ds: 0018   es: 0018   ss: 0018
Process cp (pid: 659, stackpage=c39b1000)
Stack: 00000001 0000000a c2f834e0 c6a0ee00 c6a0eecc c12e8ee0 c01ab00d c6a0ee00
       00000c0b c3a86a64 c39b1f0c 00000000 00000000 00000000 00000000 0000000a
       00000000 00000000 00000000 c011f1b0 c3a869c0 00000048 c39b1f0c c3a869c0
Call Trace: [<c01ab00d>] [<c011f1b0>] [<c013fcfe>] [<c01a9157>] [<c013fe41>] [<c012bc09>] [<c0137c24>]
       [<c012ca17>] [<c012cd2c>] [<c0106e2f>]
 
Code: 8b 43 34 89 e9 c1 ed 05 8d 14 a8 8b 42 04 0f c8 83 e1 1f bf

[-- Attachment #3: xx.messages --]
[-- Type: application/octet-stream, Size: 1521 bytes --]

Apr 17 07:49:30 harley kernel: Unable to handle kernel NULL pointer dereference at virtual address
00000034
Apr 17 07:49:30 harley kernel:  printing eip:
Apr 17 07:49:30 harley kernel: c01ac1f2
Apr 17 07:49:30 harley kernel: *pde = 00000000
Apr 17 07:49:30 harley kernel: Oops: 0000
Apr 17 07:49:30 harley kernel: CPU:    0
Apr 17 07:49:30 harley kernel: EIP:    0010:[affs_free_block+174/364]
Apr 17 07:49:30 harley kernel: EFLAGS: 00010246
Apr 17 07:49:30 harley kernel: eax: c12e8ee0   ebx: 00000000   ecx: c6a0eecc   edx: 00000c09
Apr 17 07:49:30 harley kernel: esi: c6a0ee00   edi: 00000000   ebp: 00000c09   esp: c39b1e3c
Apr 17 07:49:30 harley kernel: ds: 0018   es: 0018   ss: 0018
Apr 17 07:49:30 harley kernel: Process cp (pid: 659, stackpage=c39b1000)
Apr 17 07:49:30 harley kernel: Stack: 00000001 0000000a c2f834e0 c6a0ee00 c6a0eecc c12e8ee0 c01ab00d c6a0ee00
Apr 17 07:49:30 harley kernel:        00000c0b c3a86a64 c39b1f0c 00000000 00000000 00000000 00000000 0000000a
Apr 17 07:49:30 harley kernel:        00000000 00000000 00000000 c011f1b0 c3a869c0 00000048 c39b1f0c c3a869c0
Apr 17 07:49:30 harley kernel: Call Trace: [affs_truncate+601/956] [vmtruncate+316/328] [inode_setattr+54/164] [affs_notify_change+127/152] [notify_change+97/192] [do_truncate+73/96] [open_namei+1108/1440]
Apr 17 07:49:30 harley kernel:        [filp_open+59/92] [sys_open+56/180] [system_call+51/56]
Apr 17 07:49:30 harley kernel:
Apr 17 07:49:30 harley kernel: Code: 8b 43 34 89 e9 c1 ed 05 8d 14 a8 8b 42 04 0f c8 83 e1 1f bf

Re: amiga affs support broken in 2.4.x kernels??

[Roman Zippel]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi,

Mark Hounschell wrote:

>  Sorry I didn't get back to you yesterday afternoon. I was out of town.
>  Attached is the output from dmesg and the relavent info from
> /var/log/messages.

Could you try the attached patch? I forgot to initialize a variable
correctly.
(I also put a new version at
http://www.xs4all.nl/~zippel/affs.010417.tar.gz)

> I beleive the filesystem is ffs
> but not exactly sure. How do I tell?

It's printed if you mount with '-overbose', but it shouldn't be needed
anymore. :)

bye, Roman

[-- Attachment #2: affs.diff --]
[-- Type: text/plain, Size: 872 bytes --]

--- fs/affs/bitmap.c.org	Sat Apr  7 04:23:41 2001
+++ fs/affs/bitmap.c	Tue Apr 17 19:49:18 2001
@@ -124,7 +124,7 @@
 err_bh_read:
 	affs_error(sb,"affs_free_block","Cannot read bitmap block %u", bm->bm_key);
 	AFFS_SB->s_bmap_bh = NULL;
-	AFFS_SB->s_last_bmap = 0;
+	AFFS_SB->s_last_bmap = ~0;
 	up(&AFFS_SB->s_bmlock);
 	return;
 
@@ -262,7 +262,7 @@
 err_bh_read:
 	affs_error(sb,"affs_read_block","Cannot read bitmap block %u", bm->bm_key);
 	AFFS_SB->s_bmap_bh = NULL;
-	AFFS_SB->s_last_bmap = 0;
+	AFFS_SB->s_last_bmap = ~0;
 err_full:
 	pr_debug("failed\n");
 	up(&AFFS_SB->s_bmlock);
@@ -288,6 +288,8 @@
 		return 0;
 	}
 
+	AFFS_SB->s_last_bmap = ~0;
+	AFFS_SB->s_bmap_bh = NULL;
 	AFFS_SB->s_bmap_bits = sb->s_blocksize * 8 - 32;
 	AFFS_SB->s_bmap_count = (AFFS_SB->s_partition_size - AFFS_SB->s_reserved +
 				 AFFS_SB->s_bmap_bits - 1) / AFFS_SB->s_bmap_bits;

Re: amiga affs support broken in 2.4.x kernels??

[Mark Hounschell]

Roman Zippel wrote:
> 
> Could you try the attached patch? I forgot to initialize a variable
> correctly.
> (I also put a new version at
> http://www.xs4all.nl/~zippel/affs.010417.tar.gz)
> 
> > I beleive the filesystem is ffs
> > but not exactly sure. How do I tell?
> 
> It's printed if you mount with '-overbose', but it shouldn't be needed
> anymore. :)
> 
> bye, Roman
> 
>   ------------------------------------------------------------------------
>                 Name: affs.diff
>    affs.diff    Type: Plain Text (text/plain)
>             Encoding: 7bit
Roman,
 That seems to have done it. I'm now able to mount,read,and write to
affs
file systems. With an scsi zip drive with 3 affs partitions on it and an
affs hardfile(loop) that I use with UAE occasionally. Looks good to me.
I'll be using this functionality quite a bit so I'll notify you of any
anomalies if it's ok. Thank you for your efforts.

Regards
Mark Hounschell
markh@compro.net