From: Jeff Golds <jgolds@resilience.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc_lookup not exported
Date: Wed, 18 Apr 2001 09:37:15 -0700 [thread overview]
Message-ID: <3ADDC2BB.47C7DF0C@resilience.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0104172041330.9930-100000@weyl.math.psu.edu>
Alexander Viro wrote:
>
> On Tue, 17 Apr 2001, Jeff Golds wrote:
>
> > Hi folks.
> >
> > I noticed that proc_lookup is not exported in fs/proc/procfs_syms.c but
> > that the function is an external in include/linux/proc_fs.h.
>
> Not every public function needs to be exported. proc_lookup() is
> shared between different files in fs/proc/, so it can't be made
> static. However, it got no business being used outside of the
> fs/proc and it certainly shouldn't be used in modules.
>
I don't see why not. I created my own mkdir and rmdir handlers in my
module. I'd like to use the lookup function that proc supplies instead
of supplying my own, why shouldn't I be allowed to do that? It's not as
if I am doing something other than what normally happens: I am
assigning inode_operations::lookup to be proc_lookup.
-Jeff
--
Jeff Golds
jgolds@resilience.com
next prev parent reply other threads:[~2001-04-18 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-17 23:59 [PATCH] proc_lookup not exported Jeff Golds
2001-04-18 0:43 ` Alexander Viro
2001-04-18 16:37 ` Jeff Golds [this message]
2001-04-18 21:48 ` Alexander Viro
2001-04-18 22:46 ` Jeff Golds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ADDC2BB.47C7DF0C@resilience.com \
--to=jgolds@resilience.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox