From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Marcus Meissner <Marcus.Meissner@caldera.de>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] misplaced pci_enable_device()s in drivers/sound/
Date: Wed, 18 Apr 2001 12:55:50 -0400 [thread overview]
Message-ID: <3ADDC716.7F5B43C8@mandrakesoft.com> (raw)
In-Reply-To: <20010418182944.A25024@caldera.de>
Marcus Meissner wrote:
> Several pci_enable_device()s in drivers/sound happen _after_ accessing
> PCI resources. I have moved them before the relevant first accesses.
cool
> if (!RSRCISIOREGION(pcidev, 0))
> return -1;
can you replace this mess while you are cleaning stuff up. this, for
example, should be
if (!(pci_resource_flags(pcidev,) & IORESOURCE_IO))
There is also pci_resource_start and pci_resource_len.
> iobase = SILLY_PCI_BASE_ADDRESS(pcidev);
pci_resource_start
patch looks ok to me, but those would be nice additions...
--
Jeff Garzik | "The universe is like a safe to which there is a
Building 1024 | combination -- but the combination is locked up
MandrakeSoft | in the safe." -- Peter DeVries
next prev parent reply other threads:[~2001-04-18 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-18 16:29 [PATCH] misplaced pci_enable_device()s in drivers/sound/ Marcus Meissner
2001-04-18 16:55 ` Jeff Garzik [this message]
2001-04-18 17:20 ` Marcus Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ADDC716.7F5B43C8@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=Marcus.Meissner@caldera.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox