From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Matt_Domsch@Dell.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] adding PCI bus information to SCSI layer
Date: Mon, 23 Apr 2001 22:14:53 -0400 [thread overview]
Message-ID: <3AE4E19D.41F117C1@mandrakesoft.com> (raw)
In-Reply-To: <CDF99E351003D311A8B0009027457F140810E26A@ausxmrr501.us.dell.com>
Matt_Domsch@Dell.com wrote:
>
> > PCI ids can be derived from bus/slot/function.
>
> Even better. I'll remove the extraneous fields then, and only return those.
>
> typedef struct scsi_pci {
> unsigned char bus_number;
> unsigned int devfn; /* encoded device & function index
> */
> } Scsi_Pci;
Why not pci_dev::slot_name? Presumeably the only reason you need this
is to export it to userspace... We already have the ASCII text there,
please consider using that :)
--
Jeff Garzik | The difference between America and England is that
Building 1024 | the English think 100 miles is a long distance and
MandrakeSoft | the Americans think 100 years is a long time.
| (random fortune)
next prev parent reply other threads:[~2001-04-24 2:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-24 1:58 [RFC][PATCH] adding PCI bus information to SCSI layer Matt_Domsch
2001-04-24 2:14 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-04-23 22:06 Matt_Domsch
2001-04-23 22:27 ` Jeff Garzik
2001-04-23 23:04 ` Alan Cox
2001-04-24 3:32 ` Douglas Gilbert
2001-04-13 22:31 Matt_Domsch
2001-04-13 22:07 Douglas Gilbert
2001-04-13 22:18 ` Alan Cox
2001-04-14 16:27 ` Douglas Gilbert
2001-04-13 21:34 Matt Domsch
2001-04-14 7:35 ` Jonathan Lundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AE4E19D.41F117C1@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=Matt_Domsch@Dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox