public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alvaro Lopes <alvieboy@utad.pt>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	alvieboy@alvie.com, Herbert Xu <herbert@debian.org>
Subject: i2o_block struct gendisk misinitialization (2.4.3)
Date: Fri, 27 Apr 2001 21:48:58 +0100	[thread overview]
Message-ID: <3AE9DB3A.7437F7B2@utad.pt> (raw)

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi

i2o_block is not properly initializing its gendisk structure
(i2o_gendisk) and someone forgot to link it to the gendisk linked list,
causing i2o hard drives and partitions not to show in /proc/partitions
(debian installer relies on this to find fdisk'able drives).

I attached a simple patch to fix it.

Álvaro Lopes

[-- Attachment #2: i2o_block_gendisk_patch.diff --]
[-- Type: text/plain, Size: 655 bytes --]

--- linux-2.4.3/drivers/i2o/i2o_block.c	Sat Apr  7 16:42:21 2001
+++ linux/drivers/i2o/i2o_block.c	Fri Apr 27 19:58:41 2001
@@ -15,6 +15,8 @@
  * from loop.c. Isn't free software great for reusability 8)
  *
  * Fixes/additions:
+ *      Alvaro Lopes:
+ *              Fixed misc gendisk misinitialization
  *	Steve Ralston:	
  *		Multiple device handling error fixes,
  *		Added a queue depth.
@@ -1675,6 +1677,10 @@
 		i2o_remove_handler(&i2o_block_handler);
 		return 0;
 	}
+
+	i2ob_gendisk.next = gendisk_head;
+	gendisk_head = &i2ob_gendisk;
+	i2ob_gendisk.nr_real = MAX_I2OB;
 
 	/*
 	 *	Finally see what is actually plugged in to our controllers


             reply	other threads:[~2001-04-27 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-27 20:48 Alvaro Lopes [this message]
2001-04-30 16:08 ` i2o_block struct gendisk misinitialization (2.4.3) Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AE9DB3A.7437F7B2@utad.pt \
    --to=alvieboy@utad.pt \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alvieboy@alvie.com \
    --cc=herbert@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox