i2o_block struct gendisk misinitialization (2.4.3)

i2o_block struct gendisk misinitialization (2.4.3)

[Alvaro Lopes]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hi

i2o_block is not properly initializing its gendisk structure
(i2o_gendisk) and someone forgot to link it to the gendisk linked list,
causing i2o hard drives and partitions not to show in /proc/partitions
(debian installer relies on this to find fdisk'able drives).

I attached a simple patch to fix it.

Álvaro Lopes

[-- Attachment #2: i2o_block_gendisk_patch.diff --]
[-- Type: text/plain, Size: 655 bytes --]

--- linux-2.4.3/drivers/i2o/i2o_block.c	Sat Apr  7 16:42:21 2001
+++ linux/drivers/i2o/i2o_block.c	Fri Apr 27 19:58:41 2001
@@ -15,6 +15,8 @@
  * from loop.c. Isn't free software great for reusability 8)
  *
  * Fixes/additions:
+ *      Alvaro Lopes:
+ *              Fixed misc gendisk misinitialization
  *	Steve Ralston:	
  *		Multiple device handling error fixes,
  *		Added a queue depth.
@@ -1675,6 +1677,10 @@
 		i2o_remove_handler(&i2o_block_handler);
 		return 0;
 	}
+
+	i2ob_gendisk.next = gendisk_head;
+	gendisk_head = &i2ob_gendisk;
+	i2ob_gendisk.nr_real = MAX_I2OB;
 
 	/*
 	 *	Finally see what is actually plugged in to our controllers

Re: i2o_block struct gendisk misinitialization (2.4.3)

[Alan Cox]

> i2o_block is not properly initializing its gendisk structure
> (i2o_gendisk) and someone forgot to link it to the gendisk linked list,
> causing i2o hard drives and partitions not to show in /proc/partitions
> (debian installer relies on this to find fdisk'able drives).

This is the least of your worries. If you are using i2o use a -ac kernel
tree. There are a _lot_ of other things wrong with the base 2.4 tree and I've
not yet merged the fixes back. Many cards won't even work with the base 2.4
i2o