Re: iso9660 endianness cleanup patch

H. Peter Anvin
2001-05-01T06:19:33Z

Linus Torvalds wrote:
>
> On Mon, 30 Apr 2001, H. Peter Anvin wrote:
> >
> > The attached patch fixes both. It is against 2.4.4, but from the looks
> > of it it should patch against -ac as well.
>
> Btw, please use "static inline" instead of "extern inline", as gcc may
> decide not to inline the latter at all, leading to confusing link-time
> errors. (Gcc may also decide not to inline "static inline", but then gcc
> will output the actual body of the function out-of-line if it gets used,
> so you don't get the link-time failure).
>
> Right now only certain broken versions of gcc will actually show this
> behaviour, I think, but it's at least in theory going to be an issue.
>

I guess I personally prefer an error over completely broken behaviour,
but feel free to change it.

-hpa

--
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."