Re: iso9660 endianness cleanup patch

Pavel Machek
2001-05-04T08:10:13Z

Hi!

> > I was looking over the iso9660 code, and noticed that it was doing
> > endianness conversion via ad hoc *functions*, not even inlines; nor did
> > it take any advantage of the fact that iso9660 is bi-endian (has "all"
> > data in both bigendian and littleendian format.)
> >
> > The attached patch fixes both. It is against 2.4.4, but from the looks
> > of it it should patch against -ac as well.
>
> Please beware: There is a can of worms you are openning up here,
> since there are many broken CD producer programms out there, which
> only provide the little endian data and incorrect big endian
> entries. I had some CD's of this form myself. So the endian neutrality
> of the iso9660 is only in the theory present...

Hmm, perhaps there's time to fsck.iso9660?
Pavel
PS: It might be funny to *deliberately* create different filesystems;
one on little endian side and one on big endian side. That way windows
users would see "macs suck" and mac users "PCs suck", and that with
just one cd ;-).
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org