Re: iso9660 endianness cleanup patch

Tim Riker
2001-05-01T09:53:38Z

hpa,

I'd remove the __BIG_ENDIAN test cases if I were you. Having written
many a iso9660 decoder I will tell you that the "required" bi-endian
implementation is sometimes broken as many vendors only test CDs with a
certain single endian OS. I've seen these set to 0s, or -1 or just a
copy of the le data byte for byte. I opened many a bug report with the
different CD formatting software vendors, some fixed them, many didn't
care. The extra savings does not justify the hassles IMHO.

The other changes look great!

Tim

"H. Peter Anvin" wrote:
>
> Hi guys,
>
> I was looking over the iso9660 code, and noticed that it was doing
> endianness conversion via ad hoc *functions*, not even inlines; nor did
> it take any advantage of the fact that iso9660 is bi-endian (has "all"
> data in both bigendian and littleendian format.)
>
> The attached patch fixes both. It is against 2.4.4, but from the looks
> of it it should patch against -ac as well.
>
> -hpa
--
Tim Riker - http://rikers.org/ - short SIGs! <g>
All I need to know I could have learned in Kindergarten
... if I'd just been paying attention.