Re: [PATCH][CFT] (updated) ext2 directories in pagecache

Alexander Viro
2001-05-11T07:19:28Z

On Fri, 11 May 2001, Andreas Dilger wrote:

> I've tested again, now with kdb, and the system loops in ext2_find_entry()
> or ext2_add_link(), because there is a directory with a zero rec_len.
> While the actual cause of this problem is elsewhere, the fact that
> ext2_next_entry() will loop forever with a bad rec_len is a bug not in
> the old ext2 code.

No. Bug is that data ends up in pages without being validated. That's
the real thing to watch for - if ext2_get_page() is the only way to
get pages in cache you get all checks in one place and done once.