public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@transmeta.com>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: iso9660 endianness cleanup patch
Date: Wed, 02 May 2001 09:03:31 -0700	[thread overview]
Message-ID: <3AF02FD3.617B8EB4@transmeta.com> (raw)
In-Reply-To: <3AEE4A06.3666F4BE@transmeta.com> <3AEFCAD0.BE2A5FA@evision-ventures.com>

Martin Dalecki wrote:
> 
> "H. Peter Anvin" wrote:
> >
> > Hi guys,
> >
> > I was looking over the iso9660 code, and noticed that it was doing
> > endianness conversion via ad hoc *functions*, not even inlines; nor did
> > it take any advantage of the fact that iso9660 is bi-endian (has "all"
> > data in both bigendian and littleendian format.)
> >
> > The attached patch fixes both.  It is against 2.4.4, but from the looks
> > of it it should patch against -ac as well.
> 
> Please beware: There is a can of worms you are openning up here,
> since there are many broken CD producer programms out there, which
> only provide the little endian data and incorrect big endian
> entries. I had some CD's of this form myself. So the endian neutrality
> of the iso9660 is only in the theory present...
> 

So it has been discussed, and been updated.

	-hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt

  reply	other threads:[~2001-05-02 16:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-01  5:30 iso9660 endianness cleanup patch H. Peter Anvin
2001-05-01  6:14 ` Linus Torvalds
2001-05-01  6:18   ` H. Peter Anvin
2001-05-01 20:21     ` Pavel Machek
2001-05-04  1:51       ` Albert D. Cahalan
2001-05-04  4:59         ` Mike Galbraith
2001-05-01  6:37   ` Albert D. Cahalan
2001-05-01  9:52 ` Tim Riker
2001-05-02  8:52 ` Martin Dalecki
2001-05-02 16:03   ` H. Peter Anvin [this message]
2001-05-03 21:59   ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2001-05-01 14:40 Andrzej Krzysztofowicz
2001-05-01 18:16 ` H. Peter Anvin
2001-05-01 18:43   ` H. Peter Anvin
2001-05-01 20:44   ` Alan Cox
2001-05-01 20:59   ` Linus Torvalds
2001-05-01 21:06     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AF02FD3.617B8EB4@transmeta.com \
    --to=hpa@transmeta.com \
    --cc=dalecki@evision-ventures.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox