From: Segher Boessenkool <segher@chello.nl>
To: linux-kernel@vger.kernel.org
Subject: little patches for fbmem.c and offb.c
Date: Sat, 05 May 2001 16:39:47 +0200 [thread overview]
Message-ID: <3AF410B3.6B2E7E1B@chello.nl> (raw)
The fbmem.c bug made "less /proc/fb" segfault, as it made read()
returned more
bytes than were requested.
The offb.c bug caused /proc/fb output to be incorrect, and potentially
could cause kernel data structure corruption.
Enjoy,
Segher
--->SNIP HERE<---
diff -ur linux-2.2.19/drivers/video/fbmem.c linux-2.2.19-patched/drivers/video/fbmem.c
--- linux-2.2.19/drivers/video/fbmem.c Sat May 5 15:41:06 2001
+++ linux-2.2.19-patched/drivers/video/fbmem.c Sat May 5 15:41:06 2001
@@ -251,14 +251,16 @@
{
struct fb_info **fi;
- len = 0;
+ int buflen = 0;
for (fi = registered_fb; fi < ®istered_fb[FB_MAX] && len < 4000; fi++)
if (*fi)
- len += sprintf(buf + len, "%d %s\n",
+ buflen += sprintf(buf + buflen, "%d %s\n",
GET_FB_IDX((*fi)->node),
(*fi)->modename);
*start = buf + offset;
- return len > offset ? len - offset : 0;
+
+ buflen = buflen > offset ? buflen - offset : 0;
+ return len < buflen ? len : buflen;
}
static ssize_t
diff -ur linux-2.2.19/drivers/video/offb.c linux-2.2.19-patched/drivers/video/offb.c
--- linux-2.2.19/drivers/video/offb.c Sat May 5 16:17:28 2001
+++ linux-2.2.19-patched/drivers/video/offb.c Sat May 5 16:07:41 2001
@@ -733,7 +733,7 @@
disp->scrollmode = SCROLL_YREDRAW;
strcpy(info->info.modename, "OFfb ");
- strncat(info->info.modename, full_name, sizeof(info->info.modename));
+ strncat(info->info.modename, full_name, sizeof(info->info.modename)
- 6);
info->info.node = -1;
info->info.fbops = &offb_ops;
info->info.disp = disp;
--->SNIP HERE<---
reply other threads:[~2001-05-05 14:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AF410B3.6B2E7E1B@chello.nl \
--to=segher@chello.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox