Re: page_launder() bug

Horst von Brand
2001-05-08T03:30:35Z

"David S. Miller" <davem@redhat.com> said:
> Linus Torvalds writes:
> > The whole "dead_swap_page" optimization in the -ac tree is apparentrly
> > completely bogus. It caches a value that is not valid: you cannot
> > reliably look at whether the page has buffers etc without holding the
> > page locked.

[...]

> Please show me how this is illegal. Everyone comes to this conclusion
> when the first read the code, that I am doing something illegal, then
> when I explain what that dead_swap_page thing is doing and they read
> it a second time (how shocking! :-) they go "oh, I see".

Then it might be a better use of your time to place a comment in there
telling the gentle reader what is going on, and not tell them each time
they come asking/screaming that it is wrong. If even Linus gets confused by
it, it is mandatory IMVVHO
--
Horst von Brand vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Vin~a del Mar, Chile +56 32 672616