Re: Coding style - a non-issue

Mike Fedyk
2001-12-01T04:50:54Z

On Fri, Nov 30, 2001 at 10:07:29AM -0800, Larry McVoy wrote:
> Henning, perhaps you can explain to me how the following isn't a
>
> "I don't do XYZ"
>
> "XYZ"
>
> statement?
>
> On Fri, Nov 30, 2001 at 06:53:05PM +0100, Henning Schmiedehausen wrote:
> > You may want to know that I work in this
> > industry for about 15 years and write commercial code (that is "code
> > that ships") since about that time (and I don't run around telling
> > everybody each and every time about it and what I've already done).
>
> That would be the "I don't do XYZ..."
>
> > I've
> > written code in a good two dozen languages (including things that really
> > deserve to die like Comal) and I've worked in projects from "one man
> > show" to "lots of people in Elbonia also work on this".
>
> And this would be the "XYZ".
>
> If you are going to yell at people for a particular behaviour, it's really
> more effective if you don't show that behaviour in the midst of your yelling,
> wouldn't you agree? Just a friendly thought.
>

He's basically complaining that you like to point out what you have done in
the past a lot. Then goes to say that he has qualifications to prove that
his opinion should be listened to.

Not that I've been reading lkml long enough to notice...

> > So, please, please, Larry, _STOP THE FUCK PATRONIZING OTHERS_.
>
> It would appear that you find everything I say patronizing, regardless of
> what it is or how it is said. I'm sorry about that, but I'm not going
> to change how I speak to suit you. Yell all you want. I'd suggest
> that if you find my emails offensive, you add me to your kill file.
>

I don't know about you, but I wouldn't want to be in anyone's killfile.

> > The question now is, what is "amateur behaviour": Forcing this driver
> > writer to change or to tolerate his style in his driver? We're still
> > talking about a driver, not about the VM subsystem or the networking
> > core.
>
> Your approach to this whole topic is a good example of why I run my own
> company and I have absolute authority to fire people at will. If you
> worked here and you persisted with this approach, you would be fired,
> without question. I don't know how to say it more clearly, I don't
> say it lightly, hiring someone, training them, all of that is a huge
> investment. One which I would discard if you couldn't fit in. Coding
> style is part of fitting in, it isn't optional in any code I pay for.
>

Key words: "pay for".

This is Linux-Kernel. Each developer is on their own on how they pay the
their bills. The question is... Why not accept a *driver* that *works* but
the source doesn't look so good? Maintainability? Yes. Take the code, and
encourage better code. Or even convert said initial submission to the
kernel style.

What really needs to happen...

Accept the driver, but also accept future submissions that *only* clean up
the comments. It has been said that patches with comments and without code
have been notoriously droped.

mf