From: Jesper Juhl <juhl@eisenstein.dk>
To: Ronald Bultje <rbultje@ronald.bitfreak.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch to improve readability of sock_rcvlowat() - comments wanted...
Date: Wed, 09 May 2001 22:09:14 +0200 [thread overview]
Message-ID: <3AF9A3EA.8080209@eisenstein.dk> (raw)
In-Reply-To: <3AF72A19.7030009@eisenstein.dk> <20010507235541.Q4514@tux.bitfreak.net>
Ronald Bultje wrote:
> On 2001.05.08 01:04:57 +0200 Jesper Juhl wrote:
>
>> static inline int sock_rcvlowat(struct sock *sk, int waitall, int len)
>> {
>> int r = len;
>> if (!waitall)
>> r = min(sk->rcvlowat, len);
>> return max(1,r);
>> }
>>
>
>
> return max(1, waitall ? len : min(sk->rcvlowat, len));
>
> Although I doubt this is more readable... :-)
>
IMO your version is less readable than the 4-liner above, and the code
it generates is a lot bigger than both the original and the proposed
replacement - but thank you for the suggestion...
- Jesper Juhl - juhl@eisenstein.dk
prev parent reply other threads:[~2001-05-08 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3AF72A19.7030009@eisenstein.dk>
2001-05-07 21:55 ` Patch to improve readability of sock_rcvlowat() - comments wanted Ronald Bultje
2001-05-09 20:09 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AF9A3EA.8080209@eisenstein.dk \
--to=juhl@eisenstein.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rbultje@ronald.bitfreak.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox