From: Manfred Spraul <manfred@colorfullife.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] winbond-840 update
Date: Sat, 12 May 2001 16:43:57 +0200 [thread overview]
Message-ID: <3AFD4C2D.18095CC2@colorfullife.com> (raw)
In-Reply-To: <3AFD0A27.49C11072@colorfullife.com> <3AFD49CC.655E3E4F@mandrakesoft.com>
Jeff Garzik wrote:
>
> Manfred Spraul wrote:
> > @@ -437,9 +439,9 @@
> > if (option > 0) {
> > if (option & 0x200)
> > np->full_duplex = 1;
> > - np->default_port = option & 15;
> > - if (np->default_port)
> > - np->medialock = 1;
> > + if (option & 15)
> > + printk(KERN_INFO "%s: ignoring user supplied media type %d",
> > + dev->name, option & 15);
> > }
> > if (find_cnt < MAX_UNITS && full_duplex[find_cnt] > 0)
> > np->full_duplex = 1;
>
> I'm not sure this part is something we want in the mainstream kernel...
>
The winbond driver always ignored the user supplied media type, I only
added a warning.
medialock and default_port were write-only variables ;-)
--
Manfred
next prev parent reply other threads:[~2001-05-12 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-12 10:02 [PATCH] winbond-840 update Manfred Spraul
2001-05-12 14:33 ` Jeff Garzik
2001-05-12 14:43 ` Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-05-19 12:54 Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AFD4C2D.18095CC2@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox