public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: arjanv@redhat.com, "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Axel Thimm" <Axel.Thimm@physik.fu-berlin.de>,
	"Manuel A. McLure" <mmt@unify.com>,
	" Rasmus Bøg Hansen" <moffe@amagerkollegiet.dk>,
	"ARND BERGMANN" <std7652@et.FH-Osnabrueck.DE>,
	"Dunlap, Randy" <randy.dunlap@intel.com>,
	"Martin Diehl" <mdiehlcs@compuserve.de>,
	"Adrian Cox" <adrian@humboldt.co.uk>,
	"Capricelli Thomas" <orzel@kde.org>,
	"Ian Bicking" <ianb@colorstudy.com>,
	"John R Lenton" <john@grulic.org.ar>
Subject: PATCH 2.4.5.1: Fix Via interrupt routing issues
Date: Sun, 13 May 2001 13:28:06 -0400	[thread overview]
Message-ID: <3AFEC426.50B00B78@mandrakesoft.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

For those of you with Via interrupting routing issues (or
interrupt-not-being-delivered issues, etc), please try out this patch
and let me know if it fixes things.  It originates from a tip from
Adrian Cox... thanks Adrian!

-- 
Jeff Garzik      | Game called on account of naked chick
Building 1024    |
MandrakeSoft     |

[-- Attachment #2: via-apic.patch --]
[-- Type: text/plain, Size: 1869 bytes --]

Index: drivers/pci/quirks.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/pci/quirks.c,v
retrieving revision 1.1.1.35
diff -u -r1.1.1.35 quirks.c
--- drivers/pci/quirks.c	2001/05/02 09:26:23	1.1.1.35
+++ drivers/pci/quirks.c	2001/05/13 17:22:18
@@ -12,6 +12,7 @@
  *  use the PowerTweak utility (see http://powertweak.sourceforge.net).
  */
 
+#include <linux/config.h>
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/pci.h>
@@ -238,7 +239,34 @@
 	quirk_io_region(dev, smb, 16, PCI_BRIDGE_RESOURCES + 2);
 }
 
+
+/* we will likely need a better ifdef, something like 
+ * ifdef CONFIG_EXTERNAL_APIC
+ */
+#ifdef CONFIG_X86_IO_APIC 
+extern int nr_ioapics;
+
 /*
+ * VIA 686A/B: If an IO-APIC is active, we need to route all on-chip
+ * devices to the external APIC.
+ */
+static void __init quirk_via_ioapic(struct pci_dev *dev)
+{
+	u8 tmp;
+	
+	if (nr_ioapics < 1)
+		tmp = 0;    /* nothing routed to external APIC */
+	else
+		tmp = 0x1f; /* all known bits (4-0) routed to external APIC */
+		
+	/* Offset 0x58: External APIC IRQ output control */
+	pci_write_config_byte (dev, 0x58, tmp);
+}
+
+#endif /* CONFIG_X86_IO_APIC */
+
+
+/*
  * PIIX3 USB: We have to disable USB interrupts that are
  * hardwired to PIRQD# and may be shared with an
  * external device.
@@ -322,6 +350,14 @@
  	{ PCI_FIXUP_HEADER,	PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82371SB_2,	quirk_piix3_usb },
 	{ PCI_FIXUP_HEADER,	PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82371AB_2,	quirk_piix3_usb },
 	{ PCI_FIXUP_FINAL,	PCI_ANY_ID,		PCI_ANY_ID,			quirk_cardbus_legacy },
+
+/* we will likely need a better ifdef, something like 
+ * ifdef CONFIG_EXTERNAL_APIC
+ */
+#ifdef CONFIG_X86_IO_APIC 
+	{ PCI_FIXUP_FINAL,	PCI_VENDOR_ID_VIA,	PCI_DEVICE_ID_VIA_82C686,	quirk_via_ioapic },
+#endif
+
 	{ 0 }
 };
 

             reply	other threads:[~2001-05-13 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-13 17:28 Jeff Garzik [this message]
2001-05-13 18:38 ` PATCH 2.4.5.1: Fix Via interrupt routing issues Alan Cox
2001-05-13 18:45   ` Jeff Garzik
2001-05-13 18:47     ` Alan Cox
2001-05-14 15:21 ` Axel Thimm
2001-05-14 16:16   ` Jeff Garzik
2001-05-14 19:05     ` Axel Thimm
2001-05-14 19:14       ` Axel Thimm
2001-05-14 17:07 ` John R Lenton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AFEC426.50B00B78@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=Axel.Thimm@physik.fu-berlin.de \
    --cc=adrian@humboldt.co.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjanv@redhat.com \
    --cc=ianb@colorstudy.com \
    --cc=john@grulic.org.ar \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdiehlcs@compuserve.de \
    --cc=mmt@unify.com \
    --cc=moffe@amagerkollegiet.dk \
    --cc=orzel@kde.org \
    --cc=randy.dunlap@intel.com \
    --cc=std7652@et.FH-Osnabrueck.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox