From: Andrew Morton <andrewm@uow.edu.au>
To: Marcell GAL <cell@sch.bme.hu>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Michal Ostrowski <mostrows@styx.uwaterloo.ca>
Subject: Re: Scheduling in interrupt BUG.
Date: Mon, 14 May 2001 23:04:25 +1000 [thread overview]
Message-ID: <3AFFD7D9.67D6622A@uow.edu.au> (raw)
In-Reply-To: <3AFFBF14.7D7BAB01@sch.bme.hu>
Marcell GAL wrote:
>
> int pppoe_backlog_rcv(struct sock *sk, struct sk_buff *skb)
> {
> lock_sock(sk);
> pppoe_rcv_core(sk, skb);
> release_sock(sk);
> return 0;
> }
>
The backlog_rcv() method is called inside local_bh_disable()
and so cannot call lock_sock(). Definitely a bug in pppoe.
It looks like pppoe_backlog_rcv() should be using bh_lock_sock().
prev parent reply other threads:[~2001-05-14 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-14 11:18 Scheduling in interrupt BUG Marcell GAL
2001-05-14 12:32 ` Scheduling in interrupt BUG. [Patch] Michal Ostrowski
2001-05-14 20:21 ` Marcell Gal
2001-05-14 20:24 ` Michal Ostrowski
2001-05-14 20:45 ` Andi Kleen
2001-05-14 13:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AFFD7D9.67D6622A@uow.edu.au \
--to=andrewm@uow.edu.au \
--cc=cell@sch.bme.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@styx.uwaterloo.ca \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox