public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin.Knoblauch" <Martin.Knoblauch@TeraPort.de>
To: Bjorn Wesen <bjorn@sparta.lu.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: make menuconfig - cosmetic question
Date: Thu, 17 May 2001 17:28:30 +0200	[thread overview]
Message-ID: <3B03EE1E.5A050E1B@TeraPort.de> (raw)
In-Reply-To: <Pine.LNX.3.96.1010517151441.14658A-100000@medusa.sparta.lu.se>

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

Bjorn Wesen wrote:
> 
> While we're on cosmetics... how about imprisonment for the person who
> chose yellow on light grey for the first letters in each option...
> 
> /Bjorn
> 
> On Thu, 17 May 2001, Martin.Knoblauch wrote:
> >  this is most likely just a small issue. If I knew where to look, I
> > would try to fix it and submit a patch :-)
> >
> >  When I diff config files pocessed by "make [old]config" and "make
> > menueconfig", it seems that menuconfig is not writing out some of the
> > "comments" that the other versions do write. This is of course nothing
> > serious, but it ticks me off. Any idea where to look for this glitch?

 Now, changing that color is simple. Just change the value of TAG_KEY_FG
in scripts/lxdialog/colors.h. Unfortunatelly, this is not a question of
cosmetics, but taste. And I do not want to go into that :-)

 After some browsing around the Menuconfig script and not really
understanding how it works :-), I found the line to change. At least now
the config files look identical when processed with menuconfig (except
the fisrt comment, of course):

--- linux/Scripts/Menuconfig.orig     Thu May 17 17:19:21 2001
+++ linux/scripts/Menuconfig  Thu May 17 17:17:25 2001
@@ -1250,7 +1250,7 @@
        function comment () {
                if [ "$comment_is_option" ]
                then
-                       comment_is_option=
+                       comment_is_option=TRUE
                        echo        >>$CONFIG
                        echo "#"    >>$CONFIG
                        echo "# $1" >>$CONFIG

 Not sure whether this is worth to put into the next release - maybe
someone can spend two minutes to crosscheck.

Martin
PS: Sorry for the MIME. Should not have happend :-( Hope it is better
now.
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
IT Services              |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Card for Martin.Knoblauch --]
[-- Type: text/x-vcard; charset=us-ascii; name="Martin.Knoblauch.vcf", Size: 381 bytes --]

begin:vcard 
n:Knoblauch;Martin
tel;cell:+49-170-4904759
tel;fax:+49-89-510857-111
tel;work:+49-89-510857-309
x-mozilla-html:FALSE
url:http://www.teraport.de
org:TeraPort GmbH;IT-Services
adr:;;Garmischer Straße 4;München;Bayern;D-80339;Germany
version:2.1
email;internet:Martin.Knoblauch@TeraPort.de
title:Senior System Engineer
x-mozilla-cpt:;32160
fn:Martin Knoblauch
end:vcard

  reply	other threads:[~2001-05-17 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-17 14:07 make menuconfig - cosmetic question Martin.Knoblauch
2001-05-17 13:15 ` Bjorn Wesen
2001-05-17 15:28   ` Martin.Knoblauch [this message]
2001-05-17 16:19     ` Martin.Knoblauch
2001-05-17 17:12     ` sniffer gis88530
2001-05-17 15:18 ` make menuconfig - cosmetic question Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B03EE1E.5A050E1B@TeraPort.de \
    --to=martin.knoblauch@teraport.de \
    --cc=bjorn@sparta.lu.se \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox