public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: "J . A . Magallon" <jamagallon@able.es>
Cc: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.4-ac10
Date: Thu, 17 May 2001 15:05:14 -0400	[thread overview]
Message-ID: <3B0420EA.DD8D4015@mandrakesoft.com> (raw)
In-Reply-To: <E150QuA-0005ah-00@the-village.bc.nu> <20010517204616.K754@nightmaster.csn.tu-chemnitz.de> <20010517210023.A1052@werewolf.able.es>

"J . A . Magallon" wrote:
> --- linux-2.4.4-ac10/include/linux/raid/md_k.h.orig     Thu May 17 19:35:41
> 2001
> +++ linux-2.4.4-ac10/include/linux/raid/md_k.h  Thu May 17 19:36:15 2001
> @@ -38,6 +38,8 @@
>                 case RAID5:             return 5;
>         }
>         panic("pers_to_level()");
> +
> +       return 0;
>  }

panic should be marked attribute(noreturn), so gcc is being silly here
by warning at all.

I do this too, because IMHO its inline and won't make things bigger just
shut up the warning.  But Alan will yell at you for fixing gcc bugs in
the kernel source :)

Also, add a comment "fixes gcc warning" next to the code, so people know
why it's there.

-- 
Jeff Garzik      | Game called on account of naked chick
Building 1024    |
MandrakeSoft     |

  reply	other threads:[~2001-05-17 19:05 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-17 16:45 Linux 2.4.4-ac10 Alan Cox
2001-05-17 17:00 ` Christoph Hellwig
2001-05-17 17:36   ` Alan Cox
2001-05-17 17:16 ` Chris Evans
2001-05-17 17:37   ` Rik van Riel
2001-05-17 17:47   ` Mike Galbraith
2001-05-17 21:03     ` Rik van Riel
2001-05-18  3:55       ` Sasi Peter
2001-05-18  4:03         ` Rik van Riel
2001-05-18  6:06       ` Mike Galbraith
2001-05-18 17:08         ` Rik van Riel
2001-05-18 17:45           ` Mike Galbraith
2001-05-18 18:19             ` Ingo Oeser
2001-05-18 18:23               ` Rik van Riel
2001-05-18 18:58                 ` Ingo Oeser
2001-05-18 20:12                   ` Rik van Riel
2001-05-18 20:24                   ` Mike Galbraith
2001-05-18 20:09                 ` Mike Galbraith
2001-05-18 22:44                   ` Rik van Riel
2001-05-18 22:58                     ` Stephen C. Tweedie
2001-05-19  2:12                       ` Rik van Riel
2001-05-19  2:32                         ` Mike Castle
2001-05-19  6:45                         ` Mike Galbraith
2001-05-19  4:40                       ` Mike Galbraith
2001-05-19 17:13                       ` [RFC][PATCH] " Mike Galbraith
2001-05-19 21:41                         ` Rik van Riel
2001-05-20  3:29                           ` Mike Galbraith
2001-05-20  6:42                             ` Rik van Riel
2001-05-20  8:08                               ` Mike Galbraith
2001-05-20  8:49                                 ` Rik van Riel
2001-05-20  9:47                                   ` Mike Galbraith
2001-05-20 10:04                                     ` Rik van Riel
2001-05-21 13:36                                       ` Stephen C. Tweedie
2001-05-20 21:54                                   ` Pavel Machek
2001-05-21 20:32                                     ` David Weinehall
2001-05-23 15:34                                       ` Rik van Riel
2001-05-25  8:39                                         ` Pavel Machek
2001-05-23 17:24                                       ` Jonathan Morton
2001-05-23 17:51                                       ` Scott Anderson
2001-05-25  8:10                                         ` David Weinehall
2001-05-25 18:39                                         ` Pavel Machek
2001-06-04 19:22                                     ` RPM Installation - Compilation errors jalaja devi
2001-05-24  8:48                                   ` [RFC][PATCH] Re: Linux 2.4.4-ac10 Mike Galbraith
2001-05-24  9:10                                     ` Rik van Riel
2001-05-24 10:32                                       ` Mike Galbraith
2001-05-24 11:03                                         ` Rik van Riel
2001-05-24 14:23                                           ` Mike Galbraith
2001-05-20 15:32                             ` Ingo Oeser
2001-05-20 17:38                               ` Mike Galbraith
2001-05-20 13:44                         ` Zlatko Calusic
2001-05-20 17:58                           ` Mike Galbraith
2001-05-20 19:32                             ` Marcelo Tosatti
2001-05-20 21:37                             ` Rik van Riel
2001-05-21  3:44                               ` Mike Galbraith
2001-05-20 21:03                         ` Marcelo Tosatti
2001-05-21  3:54                           ` Mike Galbraith
2001-05-17 17:26 ` Geert Uytterhoeven
2001-05-17 18:33 ` Udo A. Steinberg
2001-05-17 18:40   ` Matti Aarnio
2001-05-17 18:51     ` Matti Aarnio
2001-05-17 19:21   ` Alan Cox
2001-05-17 18:46 ` Ingo Oeser
2001-05-17 19:00   ` J . A . Magallon
2001-05-17 19:05     ` Jeff Garzik [this message]
2001-05-17 19:26     ` Alan Cox
2001-05-17 20:52 ` Linux 2.4.4-ac10: Oops FAVRE Gregoire
2001-05-17 21:41   ` Alan Cox
2001-05-18 11:28     ` FAVRE Gregoire
  -- strict thread matches above, loose matches on Subject: below --
2001-05-18  8:12 Linux 2.4.4-ac10 David Balazic
2001-05-18  8:51 ` André Dahlqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B0420EA.DD8D4015@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ingo.oeser@informatik.tu-chemnitz.de \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox