From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Rich Baum <richbaum@acm.org>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] 2.4.5pre3 warning fixes
Date: Thu, 17 May 2001 15:48:23 -0400 [thread overview]
Message-ID: <3B042B07.25F65905@mandrakesoft.com> (raw)
In-Reply-To: <7C4D2505D3F@coral.indstate.edu>
Rich Baum wrote:
> @@ -1543,6 +1543,7 @@
> EXCEPTION(EX_INTERNAL | 0x116);
> return;
> #endif /* PARANOID */
> + ;
> }
> }
> else if ( (st0_tag == TAG_Valid) || (st0_tag == TW_Denormal) )
> @@ -437,7 +437,7 @@
> /* XXX shouldn't we *start* by deregistering the device? */
> atm_dev_deregister(fore200e->atm_dev);
>
> - case FORE200E_STATE_BLANK:
> + case FORE200E_STATE_BLANK:;
> /* nothing to do for that state */
> }
> }
> @@ -556,7 +556,7 @@
> }
> break;
> #endif
> - default:
> + default:;
> /* nothing */
> }
>
IMHO the ":;" form is really easy to miss or mistake.
Can't you put a "break;" after the "nothing" comment instead? The
compiled code is not bigger, and while the source gets a bit bigger, I
think the extra "break;" helps maintenance in the long term.
Jeff
--
Jeff Garzik | Game called on account of naked chick
Building 1024 |
MandrakeSoft |
next prev parent reply other threads:[~2001-05-17 19:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-17 19:33 [PATCH] 2.4.5pre3 warning fixes Rich Baum
2001-05-17 19:40 ` Alan Cox
2001-05-17 19:48 ` Jeff Garzik [this message]
2001-05-17 20:01 ` Mohammad A. Haque
2001-05-17 21:12 ` [PATCH] 2.4.5pre3 warning fixes -- fixed Rich Baum
-- strict thread matches above, loose matches on Subject: below --
2001-05-17 19:49 [PATCH] 2.4.5pre3 warning fixes Bingner Sam J. Contractor RSIS
2001-05-17 21:21 ` Alan Cox
2001-05-18 4:44 ` Albert D. Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B042B07.25F65905@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=richbaum@acm.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox