From: Al Borchers <alborchers@steinerpoint.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, macro@ds2.pg.gda.pl, tytso@mit.edu,
Peter Berger <pberger@brimson.com>
Subject: Re: [patch] 2.4.0, 2.2.18: A critical problem with tty_io.c
Date: Fri, 18 May 2001 04:08:36 -0500 [thread overview]
Message-ID: <3B04E694.34FA158F@steinerpoint.com> (raw)
In-Reply-To: <E150fYc-0006qG-00@the-village.bc.nu>
Alan Cox wrote:
> So I stuck my justify this change to Ted hat on. And failed.
>
> For one the cleanest way to handle all the locking is to propogate the other
> locking fix styles into both the ldisc and serial drivers. At least for 2.4
If I understand you right, the plan is to leave tty_open unchanged (it calls
driver close on failed driver open) and try to fix ldisc and serial driver
races as much as possible. Correct?
Where is an example of the "other locking fix styles" that you and Ted want
to apply to the serial drivers?
> The advantage of doing that is that modules that do play with use counts will
> not do anything worse than they do now, and will remain fully compatible.
Leaving tty_open unchanged does have compatibility going for it.
> The ldisc race is also real and completely unfixed right now.
I would be interested to try to figure this out and fix it--can you give
me more of an idea of what the problem is?
-- Al
next prev parent reply other threads:[~2001-05-18 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-17 20:00 [patch] 2.4.0, 2.2.18: A critical problem with tty_io.c Al Borchers
2001-05-17 21:23 ` Alan Cox
2001-05-18 2:12 ` Al Borchers
2001-05-18 7:50 ` Alan Cox
2001-05-18 8:24 ` Alan Cox
2001-05-18 9:08 ` Al Borchers [this message]
2001-05-18 11:25 ` Alan Cox
2001-05-18 15:22 ` Al Borchers
2001-05-18 10:09 ` Andrew Morton
2001-05-18 11:29 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2001-01-22 13:55 Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B04E694.34FA158F@steinerpoint.com \
--to=alborchers@steinerpoint.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=pberger@brimson.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox