public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <andrewm@uow.edu.au>
To: Santiago Garcia Mantinan <manty@udc.es>
Cc: linux-kernel@vger.kernel.org, Jens David <dg1kjd@afthd.tu-darmstadt.de>
Subject: Re: 8139too on 2.2.19 doesn't close file descriptors
Date: Fri, 18 May 2001 20:52:24 +1000	[thread overview]
Message-ID: <3B04FEE8.FC45EAFE@uow.edu.au> (raw)
In-Reply-To: <20010518000450.A3755@man.beta.es>

Santiago Garcia Mantinan wrote:
> 
> Hi!
> 
> I was tracking down a problem with Debian installation freezing when doing
> the ifconfig of the 8139too driver on 2.2.19 kernel, and found that this was
> caused by 8139too for 2.2.19 not closing it's file descriptors.
> 
> The original code by Jeff for the 2.4 series is ok, and searching for the
> cause of the problem I have found a difference in the way rtl8139_thread
> exits on both versions:
> 
> 2.2 version:
>         up (&tp->thr_exited);
>         return 0;
> 
> 2.4 version:
>         up_and_exit (&tp->thr_exited, 0);
> 
> I think the problem must be there, not doing the do_exit on the 2.2 version,
> but I may be wrong, can anybody look this up?

No, that's OK.

In 2.2, daemonize() does *not* do exit_files().  In 2.4
it does.  I wonder why?

Try putting an

	exit_files(current);

at the start of rtl8139_thread()

  parent reply	other threads:[~2001-05-18 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-17 22:04 8139too on 2.2.19 doesn't close file descriptors Santiago Garcia Mantinan
2000-08-03  2:38 ` Jens David
2001-05-18 10:52 ` Andrew Morton [this message]
2001-05-18 15:34   ` Santiago Garcia Mantinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B04FEE8.FC45EAFE@uow.edu.au \
    --to=andrewm@uow.edu.au \
    --cc=dg1kjd@afthd.tu-darmstadt.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manty@udc.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox