From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.4-ac11 aironet fixes
Date: Sat, 19 May 2001 18:05:28 -0400 [thread overview]
Message-ID: <3B06EE28.157D327C@mandrakesoft.com> (raw)
In-Reply-To: <200105192142.XAA02267@green.mif.pg.gda.pl>
Patch looks generally ok.
Comments:
* you forgot to cc Elmer Joandi, the maintainer, who wakes up every now
and then :)
* When is aironet4500_card version string printed, for the modular case?
* did you actually trace the code paths to mark sure code marked __init
was never called by the pcmcia hotplug part of the code? I just want to
make sure you didn't mark them __init due to an assumption based on
function name.
--
Jeff Garzik | "Do you have to make light of everything?!"
Building 1024 | "I'm extremely serious about nailing your
MandrakeSoft | step-daughter, but other than that, yes."
prev parent reply other threads:[~2001-05-19 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-19 21:42 [PATCH] 2.4.4-ac11 aironet fixes Andrzej Krzysztofowicz
2001-05-19 22:05 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B06EE28.157D327C@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox