From: Paul Gortmaker <p_gortmaker@yahoo.com>
To: Hal Duston <hald@sound.net>
Cc: linux-kernel@vger.kernel.org, rasmus@jaquet.dk
Subject: Re: PS/2 Esdi patch #8
Date: Thu, 24 May 2001 16:46:55 -0400 [thread overview]
Message-ID: <3B0D733F.1829DC88@yahoo.com> (raw)
In-Reply-To: <Pine.GSO.4.10.10105231748550.23376-200000@sound.net>
Hal Duston wrote:
> http://www.sound.net/~hald/projects/ps2esdi/ps2esdi-2.4.4-patch4
>
> Hal Duston
> hald@sound.net
You PS/2 ESDI guys might want to set the max sectors for your
driver - old default used to be 128, currently 255 (which maybe
hardware can handle ok?) - the xd and hd drivers were broken until
a similar fix was added to them.
Probably makes sense for driver to set it regardless, seeing
as default (MAX_SECTORS) has changed several times over last
few months. At least then it will be under driver control
and not at the mercy of some global value.
Paul.
--- drivers/block/ps2esdi.c~ Sun Apr 29 04:42:35 2001
+++ drivers/block/ps2esdi.c Thu May 24 16:33:46 2001
@@ -117,6 +117,7 @@
static char ps2esdi_valid[MAX_HD];
static int ps2esdi_sizes[MAX_HD << 6];
static int ps2esdi_blocksizes[MAX_HD << 6];
+static int ps2esdi_maxsect[MAX_HD << 6];
static int ps2esdi_drives;
static struct hd_struct ps2esdi[MAX_HD << 6];
static u_short io_base;
@@ -414,8 +415,11 @@
ps2esdi_gendisk.nr_real = ps2esdi_drives;
- for (i = 0; i < (MAX_HD << 6); i++)
+ /* 128 was old default, maybe maxsect=255 is ok too? - Paul G. */
+ for (i = 0; i < (MAX_HD << 6); i++) {
+ ps2esdi_maxsect[i] = 128;
ps2esdi_blocksizes[i] = 1024;
+ }
request_dma(dma_arb_level, "ed");
request_region(io_base, 4, "ed");
next prev parent reply other threads:[~2001-05-25 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-23 22:54 PS/2 Esdi patch #8 Hal Duston
2001-05-24 20:46 ` Paul Gortmaker [this message]
2001-05-25 14:46 ` Jens Axboe
2001-05-26 9:53 ` Paul Gortmaker
2001-05-26 14:49 ` A Duston
2001-05-26 14:58 ` Jens Axboe
2001-05-26 15:33 ` A Duston
2001-05-26 15:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B0D733F.1829DC88@yahoo.com \
--to=p_gortmaker@yahoo.com \
--cc=hald@sound.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox