public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: A Duston <hald@sound.net>
To: "Axboe, Jens" <axboe@suse.de>
Cc: "Gortmaker, Paul" <p_gortmaker@yahoo.com>,
	"Andersen, Rasmus" <rasmus@jaquet.dk>,
	linux-kernel@vger.kernel.org
Subject: Re: PS/2 Esdi patch #8
Date: Sat, 26 May 2001 09:49:16 -0500	[thread overview]
Message-ID: <3B0FC26B.D210E416@sound.net> (raw)
In-Reply-To: <Pine.GSO.4.10.10105231748550.23376-200000@sound.net> <3B0D733F.1829DC88@yahoo.com> <20010525164615.C14899@suse.de>

Jens Axboe wrote:

> On Thu, May 24 2001, Paul Gortmaker wrote:
> > Hal Duston wrote:
> >
> > > http://www.sound.net/~hald/projects/ps2esdi/ps2esdi-2.4.4-patch4
> > >
> > > Hal Duston
> > > hald@sound.net
> >
> > You PS/2 ESDI guys might want to set the max sectors for your
> > driver - old default used to be 128, currently 255 (which maybe
> > hardware can handle ok?) - the xd and hd drivers were broken until
> > a similar fix was added to them.
> >
> > Probably makes sense for driver to set it regardless, seeing
> > as default (MAX_SECTORS) has changed several times over last
> > few months.  At least then it will be under driver control
> > and not at the mercy of some global value.
>
> You might want to assign that max_sect array too, otherwise it's just
> going to waste space :-)
>
> Take a look at how ps2esdi handles requests -- always processing just
> the first segment. Alas, it doesn't matter how big the request is.

OK, obviously I am still missing something here from when I got the
driver booting again.  Presumably something with current_nr_sectors,
vs nr_sectors, maybe?  I thought it was odd that all the transfers were
exactly 2 blocks. I'll go ahead and take this one.  I will also go ahead
and check to see how much data the hardware can transfer at once
as well, but I expect it is quite a bit.  I am still working on getting a

group of folks to test patch #5 to see if it works as well.  Anyone
with appropriate hardware willing to test can contact me.  All I have
access to is my thinkpad 700 PS/2, and a 50Z that is a 286.

Thanks,
Hal Duston
hald@sound.net


  parent reply	other threads:[~2001-05-26 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-23 22:54 PS/2 Esdi patch #8 Hal Duston
2001-05-24 20:46 ` Paul Gortmaker
2001-05-25 14:46   ` Jens Axboe
2001-05-26  9:53     ` Paul Gortmaker
2001-05-26 14:49     ` A Duston [this message]
2001-05-26 14:58       ` Jens Axboe
2001-05-26 15:33         ` A Duston
2001-05-26 15:40           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B0FC26B.D210E416@sound.net \
    --to=hald@sound.net \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p_gortmaker@yahoo.com \
    --cc=rasmus@jaquet.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox