Re: PS/2 Esdi patch #8

Jens Axboe
2001-05-25T14:46:36Z

On Thu, May 24 2001, Paul Gortmaker wrote:
> Hal Duston wrote:
>
> > http://www.sound.net/~hald/projects/ps2esdi/ps2esdi-2.4.4-patch4
> >
> > Hal Duston
> > hald@sound.net
>
> You PS/2 ESDI guys might want to set the max sectors for your
> driver - old default used to be 128, currently 255 (which maybe
> hardware can handle ok?) - the xd and hd drivers were broken until
> a similar fix was added to them.
>
> Probably makes sense for driver to set it regardless, seeing
> as default (MAX_SECTORS) has changed several times over last
> few months. At least then it will be under driver control
> and not at the mercy of some global value.

You might want to assign that max_sect array too, otherwise it's just
going to waste space :-)

Take a look at how ps2esdi handles requests -- always processing just
the first segment. Alas, it doesn't matter how big the request is.

--
Jens Axboe