Re: [PATCH] net #9

Jean Tourrilhes
2001-05-30T02:25:40Z

On Tue, May 29, 2001 at 10:13:02PM -0400, Jeff Garzik wrote:
> *shrug* Well, if you want to go against the kernel standard that's fine
> with me. I won't put Andrzej's changes to your drivers upstream. You
> are going to continually see patches to clean that up, though, because
> it makes the end user's kernel smaller. Please consider noting this
> special case in a comment in each of your drivers "do not clean up
> static initializers" or similar.
>
> It's really a pain in the ass to remember special cases like this, so
> please reconsider. Being not-like-the-others is detrimental to the long
> term maintainability of the overall kernel.
>
> Regards,
>
> Jeff

I agree with you on the special case. I don't like it
either. Anyway, most patch to my drivers are applied wether I like it
or not, so I guess that I should be happy that I was notified and I
should sut up my big mouth because it won't make a difference.
If I reject the patch now, I will be applied behind my
back. Been there, done that.
In other words : yes, please apply the patch.

Jean