From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: jt@hpl.hp.com
Cc: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
tori@unhappy.mine.nu, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net #9
Date: Tue, 29 May 2001 22:13:02 -0400 [thread overview]
Message-ID: <3B14572E.47218B5@mandrakesoft.com> (raw)
In-Reply-To: <200105300048.CAA04583@green.mif.pg.gda.pl> <20010529180420.A14639@bougret.hpl.hp.com> <3B14493E.63F861E7@mandrakesoft.com> <20010529182506.A14727@bougret.hpl.hp.com> <3B145127.5B173DFF@mandrakesoft.com> <20010529190152.A14806@bougret.hpl.hp.com>
*shrug* Well, if you want to go against the kernel standard that's fine
with me. I won't put Andrzej's changes to your drivers upstream. You
are going to continually see patches to clean that up, though, because
it makes the end user's kernel smaller. Please consider noting this
special case in a comment in each of your drivers "do not clean up
static initializers" or similar.
It's really a pain in the ass to remember special cases like this, so
please reconsider. Being not-like-the-others is detrimental to the long
term maintainability of the overall kernel.
Regards,
Jeff
--
Jeff Garzik | Disbelief, that's why you fail.
Building 1024 |
MandrakeSoft |
next prev parent reply other threads:[~2001-05-30 2:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:48 [PATCH] net #9 Andrzej Krzysztofowicz
2001-05-30 1:04 ` Jean Tourrilhes
2001-05-30 1:13 ` Jeff Garzik
2001-05-30 1:25 ` Jean Tourrilhes
2001-05-30 1:47 ` Jeff Garzik
2001-05-30 2:01 ` Jean Tourrilhes
2001-05-30 2:13 ` Jeff Garzik [this message]
2001-05-30 2:25 ` Jean Tourrilhes
2001-05-30 16:35 ` Hermann Himmelbauer
2001-05-30 2:13 ` Jean Tourrilhes
2001-05-30 2:17 ` Jeff Garzik
2001-05-30 9:33 ` Henning P. Schmiedehausen
2001-05-30 22:28 ` Pavel Machek
2001-05-30 9:32 ` Henning P. Schmiedehausen
2001-05-30 10:28 ` Andrzej Krzysztofowicz
2001-05-30 10:30 ` Keith Owens
2001-05-30 10:43 ` Henning P. Schmiedehausen
2001-05-30 10:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B14572E.47218B5@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tori@unhappy.mine.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox